Changeset 166 for trunk

Timestamp:

06/10/12 20:45:54 (13 years ago)

Author:

kdeugau

Message:

/trunk

Fix a couple of bizarre internationalization/localization bugs.

Robert M. Stockmann provided a patch that fixes up a very strange
issue with the fakeroot call; in several locales other than en_US.utf8,
Something Funky Happens(TM) and fakeroot gets confused about arguments
somewhere down the chain that should be passed to the command it's
wrappering. (Ab)using the -- argument for fakeroot makes it behave
without any apparent side effects - although arguably there's nothing
there that should cause it to *mis*behave in the first place, and the real
bug is either Perl's UTF8 handling somewhere or fakeroot's mangling of
arguments.

While checking that issue, I also uncovered another similar glitch in the
automagical library provides/depends/etc mechanism; adding LANG=C before
the ldd call forces it back to output that the following code understands.
This doesn't need to allow translated strings through, because all it needs
are the library names.

File:

• trunk/debbuild (modified) (2 diffs)

trunk/debbuild

@@ -1267 +1267 @@
         or die "Can't open/create package-creation script file $debscriptfile: $!\n";
     print DEBSCRIPT $scriptletbase;
-    print DEBSCRIPT "fakeroot dpkg-deb -b $specglobals{buildroot}/$pkg $topdir/DEBS/$pkgdata{$pkg}{arch}/".
+    print DEBSCRIPT "fakeroot -- dpkg-deb -b $specglobals{buildroot}/$pkg $topdir/DEBS/$pkgdata{$pkg}{arch}/".
         "$pkgdata{$pkg}{name}_".
         (defined($pkgdata{main}{epoch}) ? "$pkgdata{main}{epoch}:" : '').
@@ -1521 +1521 @@
   my @reqlist;
   foreach (@binlist) {
-    push @reqlist, qx { ldd $_ };
+    push @reqlist, qx { LANG=C ldd $_ };
   }