Changeset 180

Timestamp:

12/02/11 16:40:12 (12 years ago)

Author:

Kris Deugau

Message:

/trunk

Apply scope checks on user and domain for logs. Scope checks
for group logs are applied through the change-group check since
the group log is for the current group instead of user input.
See #30.

Location:

trunk

Files:

• dns.cgi (modified) (3 diffs)
• templates/log.tmpl (modified) (1 diff)

trunk/dns.cgi

@@ -1456 +1456 @@
   my $id = $curgroup;  # we do this because the group log may be called from (almost) any page,
                        # but the others are much more limited.  this is probably non-optimal.
+
   if ($webvar{ltype} && $webvar{ltype} eq 'user') {
     $sql .= "user_id=?";
     $id = $webvar{id};
+    if (!check_scope(id => $id, type => 'user')) {
+      $page->param(errmsg => "You are not permitted to view log entries for the requested user");
+      goto DONELOG;
+    }
     $page->param(logfor => 'user '.userFullName($dbh,$id));
   } elsif ($webvar{ltype} && $webvar{ltype} eq 'dom') {
     $sql .= "domain_id=?";
     $id = $webvar{id};
+    if (!check_scope(id => $id, type => 'domain')) {
+      $page->param(errmsg => "You are not permitted to view log entries for the requested domain");
+      goto DONELOG;
+    }
     $page->param(logfor => 'domain '.domainName($dbh,$id));
   } else {
@@ -1468 +1477 @@
     $sql .= "group_id=?";
     $page->param(logfor => 'group '.groupName($dbh,$id));
+    # note that scope limitations are applied via the change-group check;
+    # group log is always for the "current" group
   }
   my $sth = $dbh->prepare($sql);
@@ -1482 +1493 @@
   }
   $page->param(logentries => \@logbits);
+
+  # scope check fail target
+  DONELOG: ;
 
 } # end $webvar{page} dance

trunk/templates/log.tmpl

@@ -4 +4 @@
 
 <td align="center" valign="top">
+
+<TMPL_IF errmsg>
+<div class='errmsg'><TMPL_VAR NAME=errmsg></div>
+</TMPL_IF>
 
 <table border="0" width="90%">