Changeset 326 for trunk

Timestamp:

05/02/12 17:41:48 (13 years ago)

Author:

Kris Deugau

Message:

/trunk

Move SQL for clone-this-user dropdown into DNSDB.pm. See #1

Location:

trunk

Files:

• DNSDB.pm (modified) (3 diffs)
• dns.cgi (modified) (1 diff)

trunk/DNSDB.pm

@@ -44 +44 @@
         &getGroupCount &getGroupList
         &addUser &updateUser &delUser &userFullName &userStatus &getUserData
-        &getUserCount &getUserList
+        &getUserCount &getUserList &getUserDropdown
         &getSOA &updateSOA &getRecLine &getDomRecs &getRecCount
         &addRec &updateRec &delRec
@@ -69 +69 @@
                 &getGroupCount &getGroupList
                 &addUser &updateUser &delUser &userFullName &userStatus &getUserData
-                &getUserCount &getUserList
+                &getUserCount &getUserList &getUserDropdown
                 &getSOA &updateSOA &getRecLine &getDomRecs &getRecCount
                 &addRec &updateRec &delRec
@@ -2427 +2427 @@
   return $ulist;
 } # end getUserList()
+
+
+## DNSDB::getUserDropdown()
+# Get a list of usernames for use in a dropdown menu.
+# Takes a database handle, current group, and optional "tag this as selected" flag.
+# Returns a reference to a list of hashrefs suitable to feeding to HTML::Template
+sub getUserDropdown {
+  my $dbh = shift;
+  my $grp = shift;
+  my $sel = shift || 0;
+
+  my $sth = $dbh->prepare("SELECT username,user_id FROM users WHERE group_id=?");
+  $sth->execute($grp);
+
+  my @userlist;
+  while (my ($username,$uid) = $sth->fetchrow_array) {
+    my %row = (
+        username => $username,
+        uid => $uid,
+        selected => ($sel == $uid ? 1 : 0)
+        );
+    push @userlist, \%row;
+  }
+  return \@userlist;
+} # end getUserDropdown()
 
 

trunk/dns.cgi

@@ -1828 +1828 @@
 
 sub fill_clonemelist {
-  my $sth = $dbh->prepare("SELECT username,user_id FROM users WHERE group_id=$curgroup");
-  $sth->execute;
-
   # shut up some warnings, but don't stomp on caller's state
   local $webvar{clonesrc} = 0 if !defined($webvar{clonesrc});
 
-  my @clonesrc;
-  while (my ($username,$uid) = $sth->fetchrow_array) {
-    my %row = (
-        username => $username,
-        uid => $uid,
-        selected => ($webvar{clonesrc} == $uid ? 1 : 0)
-        );
-    push @clonesrc, \%row;
-  }
-  $page->param(clonesrc => \@clonesrc);
+  my $clones = getUserDropdown($dbh, $curgroup, $webvar{clonesrc});
+  $page->param(clonesrc => $clones);
 }