Changeset 407

Timestamp:

10/05/12 12:45:23 (12 years ago)

Author:

Kris Deugau

Message:

/trunk

Check and fix addGroup and delGroup in dns-rpc.cgi. See #43.

File:

• trunk/dns-rpc.cgi (modified) (3 diffs)

trunk/dns-rpc.cgi

@@ -173 +173 @@
 
   _commoncheck(\%args, 'y');
-
-# not sure how to usefully represent permissions from any further out from DNSDB.pm :/
+  die "Missing new group name\n" if !$args{groupname};
+  die "Missing parent group ID\n" if !$args{parent_id};
+
+# not sure how to usefully represent permissions via RPC.  :/
 # not to mention, permissions are checked at the UI layer, not the DB layer.
   my $perms = {domain_edit => 1, domain_create => 1, domain_delete => 1,
@@ -189 +191 @@
 
   _commoncheck(\%args, 'y');
+  die "Missing group ID or name to remove\n" if !$args{group};
 
   my ($code,$msg);
@@ -196 +199 @@
   } else {
     my $grpid = DNSDB::groupID($dbh, $args{group});
-    die "Can't find group" if !$grpid;
+    die "Can't find group\n" if !$grpid;
     ($code,$msg) = DNSDB::delGroup($dbh, $grpid);
   }
   die $msg if $code eq 'FAIL';
+  return $msg;
 }