Changeset 551 for trunk

Timestamp:

12/12/13 15:46:34 (11 years ago)

Author:

Kris Deugau

Message:

/trunk

Fix nagging session-handling bug; cookie would expire but not session
(leaving you logged in, with no priviledges), or you could be active
but suddenly the session would expire based on your original login, not
last activity time.

File:

• trunk/dns.cgi (modified) (3 diffs)

trunk/dns.cgi

@@ -99 +99 @@
         or die CGI::Session->errstr();
 
-if (!$sid) {
+if (!$sid || $session->is_expired) {
   $webvar{page} = 'login';
 } else {
@@ -218 +218 @@
 }
 
-my $sesscookie;
+my $sesscookie = $q->cookie( -name => 'dnsadmin_session',
+        -value => $sid,
+#        -expires => "+".$dnsdb->{timeout},
+        -secure => 0,
+## fixme:  need to extract root path for cookie, so as to limit cookie to dnsadmin instance
+#        -path => $url
+        );
 
 # handle can-happen-on-(almost)-any-page actions
@@ -237 +243 @@
       $sesscookie = $q->cookie( -name => 'dnsadmin_session',
         -value => $sid,
-        -expires => "+".$dnsdb->{timeout},
+#        -expires => "+".$dnsdb->{timeout},
         -secure => 0,
 ## fixme:  need to extract root path for cookie, so as to limit cookie to dnsadmin instance