Changeset 639

Timestamp:

06/03/14 17:52:24 (10 years ago)

Author:

Kris Deugau

Message:

/trunk

Add a little more checking to AXFR imports; warn but do not discard
on bare IP addresses (or things-that-look-like-IP-addresses) for NS,
CNAME, and SRV records.

File:

• trunk/DNSDB.pm (modified) (2 diffs)

trunk/DNSDB.pm

@@ -5148 +5148 @@
         next if ($args{rwns} && ($host eq $zone));
         $val = $rr->nsdname;
+        $warnmsg .= "Suspect record '".$rr->string."' may not be imported correctly: NS records may not be bare IP addresses\n"
+          if $val =~ /^(?:(?:\d+\.){3}\d+|[a-fA-F0-9:]+)$/;
         $nsflag = 1;
       } elsif ($type eq 'CNAME') {
         $val = $rr->cname;
+        $warnmsg .= "Suspect record '".$rr->string."' may not be imported correctly: CNAME records may not be bare IP addresses\n"
+          if $val =~ /^(?:(?:\d+\.){3}\d+|[a-fA-F0-9:]+)$/;
       } elsif ($type eq 'SOA') {
         next if $args{rwsoa};
@@ -5181 +5185 @@
         $weight = $rr->weight;
         $port = $rr->port;
+        $warnmsg .= "Suspect record '".$rr->string."' may not be imported correctly: SRV records may not be bare IP addresses\n"
+          if $val =~ /^(?:(?:\d+\.){3}\d+|[a-fA-F0-9:]+)$/;
       } elsif ($type eq 'KEY') {
         # we don't actually know what to do with these...