Changeset 674

Timestamp:

01/15/15 15:36:22 (10 years ago)

Author:

Kris Deugau

Message:

/trunk

Fill in _validate_65284 so that it doesn't just blindly accept gibberish.

Still need to fill in a segment for export of these AAAA+PTR template
records; can't expand them the way A+PTR template records get handled.

Add a little more checking in addRec() to make sure we have both a host

and value.

File:

• trunk/DNSDB.pm (modified) (2 diffs)

trunk/DNSDB.pm

@@ -1313 +1313 @@
 # AAAA+PTR template record
 # Not sure this can be handled sanely due to the size of IPv6 address space
+# _validate_65283 above should handle v6 template records fine.  It's on export we've got trouble.
 sub _validate_65284 {
-  return ('OK','OK');
+  my $self = shift;
+  my %args = @_;
+
+  # do a quick check on the form of the hostname part;  this is effectively a
+  # "*.0.0.f.ip6.arpa" hostname, not an actual expandable IP template pattern
+  # like with 65283.
+  return ('FAIL', $errstr)
+        if !_check_hostname_form(${$args{host}}, ${$args{rectype}}, $args{defrec}, $args{revrec});
+  return $self->_validate_65283(%args);
 } # done AAAA+PTR template record
 
@@ -4171 +4180 @@
   my $stamp = shift;
   $stamp = '' if !$stamp;        # Timestamp should be a string at this point.
+
+  # extra safety net - apparently RPC can squeak this by.  O_o
+  return ('FAIL', "host must contain a value") if !$$host;
+  return ('FAIL', "val must contain a value") if !$$val;
 
   # Spaces are evil.