Changeset 686

Timestamp:

07/27/15 17:39:44 (9 years ago)

Author:

Kris Deugau

Message:

/trunk

• Tweak call to DNSDB::_template4_expand() in templatesToRecords() for _template4_expand()'s changes
• Note a couple of distant edge case buglets for future consideration

File:

• trunk/dns-rpc.cgi (modified) (3 diffs)

trunk/dns-rpc.cgi

@@ -538 +538 @@
   my $cidr = new NetAddr::IP $args{cidr};
 
+##fixme:  Minor edge case; if we receive calls one after the other to update
+# to the same thing, we bulk out the log with useless notices.  Leaving this
+# for future development since this should be rare in practice.
+
   my $zonelist = $dnsdb->getZonesByCIDR(%args);
   if (scalar(@$zonelist) == 0) {
@@ -803 +807 @@
           next if $iplist{$ip};
           my $newhost = $host;
-          DNSDB::_template4_expand(\$newhost, $ip->addr);
+          $dnsdb->_template4_expand(\$newhost, $ip->addr);
           $insth->execute($domid, $zid, $newhost, $type, $ip->addr, $ttl, $loc);
           $iplist{$ip}++;
@@ -871 +875 @@
             my ($code,$msg) = $dnsdb->delRec('n', 'y', $rec->{record_id});
           } else {
+##fixme: AAAA+PTR?
             my $ret = $dnsdb->downconvert($rec->{record_id}, $DNSDB::reverse_typemap{A});
           }