Changeset 795

Timestamp:

11/03/20 13:13:33 (4 years ago)

Author:

Kris Deugau

Message:

/trunk

Commit expanded serial incrementer.

File:

• trunk/DNSDB.pm (modified) (1 diff)

trunk/DNSDB.pm

@@ -505 +505 @@
   my %args = @_;
 
-##fixme:  add alternate serial schemes here
+##fixme:  refine to adjust for serial wraparound, ie, if switching from ISO to Unix,
+# the serial effectively runs backwards.  technically this breaks AXFR slaves.
+
+  # heavy lifting done in this sub-sub.  updates may be needed on a forward zone, reverse zone, or both, depending.
+  sub __doupdate {
+    my $rev = shift;
+    my $zid = shift;
+    my $tname = _zonetable('n', $rev);
+    my $pname = _recparent('n', $rev);
+    my ($sertype,$serial) = $dbh->selectrow_array("SELECT sertype,zserial FROM $tname WHERE $pname = ?", undef, $zid) or die $dbh->errstr;
+    if ($sertype eq 'U') {
+      # Unix timestamp
+      $dbh->do("UPDATE $tname SET changed = 'y',zserial = ? WHERE $pname = ?", undef, (scalar(time), $zid) );
+    } elsif ($sertype eq 'D') {
+      # ISO datestamp (YYYYMMDDnn)
+      my $newserial = strftime("%Y%m%d00", localtime);
+      if ($newserial > $serial) {
+        # new day, use the new serial
+        $serial = $newserial;
+      } else {
+        # change on same day, increment existing serial
+        $serial++;
+##fixme:  do we need to check for overflow?  (eg 2020091599 -> 2020091600 despite not being 2020-09-16)
+# technically yes, practically no (effectively falls back to a variation of the simple sequential update)
+# - might be a local policy violation.  also, any such zone is probably better served by a fixed stub
+# and DDNS as supported by BIND etc
+      }
+      $dbh->do("UPDATE $tname SET changed = 'y',zserial = ? WHERE $pname = ?", undef, ($serial, $zid) );
+    } elsif ($sertype eq 'S') {
+      # Simple sequential number
+      $dbh->do("UPDATE $tname SET changed = 'y', zserial = zserial + 1 WHERE $pname = ?", undef, $zid );
+    } else {
+##fixme:  just fall back to simple sequential?  shouldn't be possible to have any value other than U, D, or S
+      # Your llama is on fire
+    }
+  }
 
   if ($args{rdns_id}) {
-    $dbh->do("UPDATE revzones SET changed = 'y',zserial = ? WHERE rdns_id = ?", undef, (scalar(time), $args{rdns_id}) );
-  }
+    __doupdate('y', $args{rdns_id});
+  }
+
   if ($args{domain_id}) {
-    $dbh->do("UPDATE domains SET changed = 'y',zserial = ? WHERE domain_id = ?", undef, (scalar(time), $args{domain_id}) );
-  }
+    __doupdate('n', $args{domain_id});
+  }
+
 } # end _updateserial()