Changeset 804

Timestamp:

11/09/20 18:21:27 (5 years ago)

Author:

Kris Deugau

Message:

/trunk

Fix mysterious 'Variable "$foo" will not stay shared at ...' error by
converting the nested sub in _updateserial() to an anonymous sub, because
nested subs aren't really a properly supported thing as per eg
​https://www.perlmonks.org/bare/?node_id=137292.

Several other instances of nested subs should arguably be converted as well,
although they shouldn't matter so much as they haven't triggered the error,
and as of a quick review don't make use of "parent" sub variables the way
the one in _updateserial() did.

File:

• trunk/DNSDB.pm (modified) (2 diffs)

trunk/DNSDB.pm

@@ -508 +508 @@
 # the serial effectively runs backwards.  technically this breaks AXFR slaves.
 
+##perlnote
+# Nested subs... aren't.  Subs have file or execution scope, sort of (not sure which ATM), so we
+# have to abuse the "anonymous sub" construct and bend our code in a pretzel to work around this limitation.
+
   # heavy lifting done in this sub-sub.  updates may be needed on a forward zone, reverse zone, or both, depending.
-  sub __doupdate {
+  my $serup = sub {
     my $rev = shift;
     my $zid = shift;
@@ -540 +544 @@
       # Your llama is on fire
     }
-  }
+  };
 
   if ($args{rdns_id}) {
-    __doupdate('y', $args{rdns_id});
+    &$serup('y', $args{rdns_id});
   }
 
   if ($args{domain_id}) {
-    __doupdate('n', $args{domain_id});
+    &$serup('n', $args{domain_id});
   }