Changeset 821

Timestamp:

12/04/20 13:26:33 (3 years ago)

Author:

Kris Deugau

Message:

/trunk

Fourtheenth sampled iteration of bind-import

File:

• trunk/bind-import (modified) (8 diffs)

trunk/bind-import

@@ -31 +31 @@
 
 my $dnsdb = new DNSDB;
-my $doimport = 1;
+my $dryrun = 0;
 
 #print Dumper(\%reverse_typemap);
@@ -59 +59 @@
         "skip=s" => \@skipdefs,
         "skipfile=s" => \$skipfile,
-        "test|dry-run" => sub { $doimport = 0; },
+        "test|dry-run" => \$dryrun,
 );
 
@@ -72 +72 @@
                 A file containing patterns to skip.  Patterns from the file and
                 any --skip arguments are merged.
+        --dry-run
+                Do everything except finalize the import
         zonename
                 The name of the zone to import.  Required.
@@ -131 +133 @@
 ##fixme:  this is wrong, BIND zone files are generally complete and we're adding.  merging records is an entire fridge full of worms.
 ##fixme:  for import, should arguably check for zone *non*existence
+
   if ($zname =~ /\.arpa\.?$/ || $zname =~ m,^[\d./]+$,) {
     $rev = 'y';
@@ -137 +140 @@
     if ($zid) {
       die "zone $origzone already present, not merging records\n";
-      $zname = new NetAddr::IP $zname;
-      $zname = DNSDB::_ZONE($zname, 'ZONE', 'r', '.').($zname->{isv6} ? '.ip6.arpa' : '.in-addr.arpa');
+#print "dbg: skip add domain\n";
+#      $zname = new NetAddr::IP $zname;
+#      $zname = DNSDB::_ZONE($zname, 'ZONE', 'r', '.').($zname->{isv6} ? '.ip6.arpa' : '.in-addr.arpa');
     }
     ($zid) = $dnsdb->{dbh}->selectrow_array("INSERT INTO revzones (revnet,group_id,status,default_location,zserial) VALUES (?,?,?,?,?) RETURNING rnds_id",
@@ -144 +148 @@
 
   } else {
-print "dbg: forward zone\n";
     $zid = $dnsdb->domainID($zname,':ANY:');
     if ($zid) {
-#      die "zone $origzone already present, not merging records\n";
-print "dbg: skip add domain\n";
-    } else {
-      ($zid) = $dnsdb->{dbh}->selectrow_array("INSERT INTO domains (domain,group_id,status,default_location,zserial) VALUES (?,?,?,?,?) RETURNING domain_id",
+      die "zone $origzone already present, not merging records\n";
+#print "dbg: skip add domain\n";
+    }
+    ($zid) = $dnsdb->{dbh}->selectrow_array("INSERT INTO domains (domain,group_id,status,default_location,zserial) VALUES (?,?,?,?,?) RETURNING domain_id",
         undef, ($zname, $group, $status, $location, $serial));
-    }
 
   }
@@ -557 +559 @@
     }
 
-no warnings qw(uninitialized);
-#print "parsed: '$curlabel' '$class' '$ttl' '$type'->'$itype' '$rdata'\n";
-#print;
-#;imap   IN      900     CNAME   deepnet.cx.
-##fixme:  not sure how to handle the case where someone leaves off the class.
-    if ($doimport) {
+##fixme:  need to dig out a subtransaction widget or extract a core of addRec() that doesn't dbh->commit(), so --dry-run works
+#    unless ($dryrun) {
       my ($code, $msg);
       if ($rev eq 'n') {
@@ -572 +570 @@
       }
       print "$code: $msg\n" if $code ne 'OK';
-    }
+#    }
 #  $i++;
   }
 
+  if ($dryrun) {
+    $dnsdb->{dbh}->rollback;
+  } else {
+    $dnsdb->{dbh}->commit;
+  }
 };
 if ($@) {