Changeset 905

Timestamp:

08/11/25 17:00:31 (5 hours ago)

Author:

Kris Deugau

Message:

/trunk

Ad hoc patches from workspace: Clean up passed CIDR validation in
RPC delByCIDR() so we don't end up with a DNS lookup result from a non-IP
value that happens to resolve

File:

• trunk/dns-rpc.cgi (modified) (1 diff)

trunk/dns-rpc.cgi

@@ -1641 +1641 @@
   die "Need location\n" if !defined($args{location});
 
+  # quick sanity-check version
+  die "CIDR is either poorly formed or not an IP/netblock at all\n" if !DNSDB::_maybeip(\$args{cidr});
+  my $cidr = new NetAddr::IP $args{cidr};
+  die "CIDR is not a valid IP/netblock\n" if !$cidr;
+
   # much like addOrUpdateRevRec()
   my $zonelist = $dnsdb->getZonesByCIDR(%args);
-  my $cidr = new NetAddr::IP $args{cidr};
 
   if (scalar(@$zonelist) == 0) {