Changeset 954

Timestamp:

12/30/25 13:56:27 (2 hours ago)

Author:

Kris Deugau

Message:

/branches/cname-collision

Fix another patch-shuffling oops; accidentally duplicated a test instead
of copying in the appropriate variantion.
See #72, #88

File:

• branches/cname-collision/t/cname.t (modified) (1 diff)

branches/cname-collision/t/cname.t

@@ -34 +34 @@
 };
 
-subtest 'CNAME add - existing/colliding CNAME' => sub {
-  $newname = 'www.example.com';
+subtest 'CNAME add - existing/colliding non-CNAME' => sub {
+  $newname = 'mx1.example.com';
   ($code, $msg) = $dnsdb->addRec('n', 'n', 1, \$newname, \$rectype, \$newval, 900);
-  ok( $code eq 'FAIL', "addRec() claimed failure adding duplicate CNAME" );
+  ok( $code eq 'FAIL', "addRec() claimed failure" );
   if ($code eq 'FAIL') {
-    ($rcount) = $dbh->selectrow_array("SELECT count(*) FROM records WHERE domain_id = 1 AND host = '$newname' AND type = 5");
-    ok( $rcount == 1, " ... [$rcount] CNAME already exists" );
-    like( $msg, qr/already a CNAME present/, " ... returned matching error" );
+    ($rcount) = $dbh->selectrow_array("SELECT count(*) FROM records WHERE domain_id = 1 AND host = '$newname' AND type <> 5");
+    ok( $rcount == 2, " ... [$rcount] record(s) with $newname already exist" );
+    like( $msg, qr/One or more non-CNAME records/, " ... returned matching error" );
   }
-};
+}; 
 
 subtest 'CNAME add - existing/colliding CNAME' => sub {