Changeset 57

Timestamp:

12/12/14 12:18:54 (10 years ago)

Author:

Kris Deugau

Message:

/trunk/dnsbl

Fix snafu with adding an IP that's not in a known block; the browse
"sidebar" listing was trying to browse the entire dataset instead of
properly showing nothing.

File:

• trunk/dnsbl/DNSBLweb.pm (modified) (2 diffs)

trunk/dnsbl/DNSBLweb.pm

@@ -37 +37 @@
     return;
   }
-  my $ret;
+  my $ret = '';
 
   my %args = @_;
   $args{ipseen} = \%ipseen if !defined($args{ipseen});
-  my $pblock = $args{block} || '0/0';
   my $ip;  
   if ($args{ip}) {
@@ -49 +48 @@
   }
   my $ipcidr = new NetAddr::IP $ip;
+  if (!$args{block}) {
+    # Safety net - Don't try to return the entire dataset if we were only passed an IP that
+    # is not in a known block
+    ($args{block}) = $dbh->selectrow_array("SELECT block FROM blocks WHERE block >> ? AND level=0", undef, $ip);
+    return '' if !$args{block};
+  }
+  my $pblock = $args{block} || '0/0';
 
   my $basesql = "SELECT b.block,o.orgname,b.listme,o.listme,b.comments,o.comments ".