Changeset 113 for branches

Timestamp:

12/31/04 11:50:32 (20 years ago)

Author:

Kris Deugau

Message:

/branches/stable

First-pass patch to avoid just hanging if the billing host to check
customer IDs against fails.

File:

• branches/stable/cgi-bin/CustIDCK.pm (modified) (1 diff)

branches/stable/cgi-bin/CustIDCK.pm

@@ -32 +32 @@
 
 # some example code for a database check
-  my $dbh = DBI->connect ("DBI:Pg:host=billing;dbname=custids", "cidcheck", "c1dch4ck");
+  # Try to catch failures to connect.  If the remote server is up but
+  # not responding (this has HAPPENED) we need to break out rather than hanging.
+  eval {
+    local $SIG{ALRM} = sub { die "failed connection to billing!!" };
+    alarm 3;    # 3-second timeout.  This may be too aggressive.
+    my $dbh = DBI->connect ("DBI:Pg:host=billing;dbname=custids", "cidcheck", "c1dch4ck");
+    alarm 0;    # cancel the alarm
+  };
+  alarm 0;      # avoid race conditions.  May not be needed here.  (Hah!)
+  if ($@ && $@ !~ /failed connection to billing!!/) {
+    $CustIDCK::Error = 1;
+    $CustIDCK::ErrMsg = "Failed connection to billing DB host!  Unable to verify CustIDs.";
+    return 0;
+  }
+
   my $sth = $dbh->prepare("SELECT custid FROM custid WHERE custid = '$custid';");
   $sth->execute;