Changeset 151 for branches

Timestamp:

02/04/05 11:04:55 (20 years ago)

Author:

Kris Deugau

Message:

/branches/stable

More bugfixes and error-trapping to make sure we don't just
crash and burn with a cryptic error code when the billing DB is down.

File:

• branches/stable/cgi-bin/CustIDCK.pm (modified) (2 diffs)

branches/stable/cgi-bin/CustIDCK.pm

@@ -38 +38 @@
     local $SIG{ALRM} = sub { die "failed connection to billing!!" };
     alarm 3;    # 3-second timeout.  This may be too aggressive.
-    $dbh = DBI->connect ("DBI:Pg:host=billing;dbname=custids", "cidcheck", "c1dch4ck");
+
+    eval {
+      $dbh = DBI->connect ("DBI:Pg:host=billing;dbname=custids", "cidcheck", "c1dch4ck");
+      die "failed connection to billing!!" if !$dbh;
+# Not certain if this is needed here.  It doesn't seem to be.
+#      $dbh->ping;      # Gotta do this to "force" a "failure".  NRGH.
+    };
     alarm 0;    # cancel the alarm
+    $dbh->ping; # Gotta do this to "force" a "failure".  NRGH.
   };
   alarm 0;      # avoid race conditions.  May not be needed here.  (Hah!)
@@ -48 +55 @@
   }
 
-  my $sth = $dbh->prepare("SELECT custid FROM custid WHERE custid = '$custid';");
+  # We should have a valid DB connection by now.
+  my $sth = $dbh->prepare("SELECT custid FROM custid WHERE custid = '$custid'");
   $sth->execute;
   if ($dbh->err) {