Changeset 211

Timestamp:

04/04/05 17:19:24 (20 years ago)

Author:

Kris Deugau

Message:

/branches/stable

Fixed bug-in-waiting that would create some... odd... results
while assigning a static IP if the poolips data gets a little wonky.

This removes a ##fixme note! w00t!

File:

• branches/stable/cgi-bin/main.cgi (modified) (2 diffs)

branches/stable/cgi-bin/main.cgi

@@ -820 +820 @@
   if ($webvar{alloctype} =~ /^.i$/) {
     my ($base,undef) = split //, $webvar{alloctype};    # split into individual chars
-    my $sql;
-    # Check for pools in Subury or North Bay if DSL or server pool.  Anywhere else is
-    # invalid and shouldn't be in the db in the first place.
+    my ($sql,$city);
+    # Check for pools in Subury, North Bay, or Toronto if DSL or server pool.
+    # Anywhere else is invalid and shouldn't be in the db in the first place.
     # ... aside from #^%#$%#@#^%^^!!!! legacy data.  GRRR.
     # Note that we want to retain the requested city to relate to customer info.
-##fixme This needs thought.
-##SELECT DISTINCT pool, Count(*) FROM poolips where available='y' GROUP BY pool;
     if ($base =~ /^[ds]$/) {
-      $sql = "select * from poolips where available='y' and".
-        " type='$webvar{alloctype}' and (city='Sudbury' or city='North Bay' or city='Toronto')";
+      $city = "(allocations.city='Sudbury' or allocations.city='North Bay' or ".
+        "allocations.city='Toronto')";
     } else {
-      $sql = "select * from poolips where available='y' and".
-        " type='$webvar{alloctype}' and city='$webvar{pop}'";
-    }
-
-    # Now that we know where we're looking, we can list the pools with free IPs.
-    $sth = $ip_dbh->prepare($sql);
+      $city = "allocations.city='$webvar{pop}'";
+    }
+
+# Ewww.  But it works.
+    $sth = $ip_dbh->prepare("SELECT (SELECT city FROM allocations WHERE cidr=poolips.pool), ".
+        "poolips.pool, COUNT(*) FROM poolips,allocations WHERE poolips.available='y' AND ".
+        "poolips.pool=allocations.cidr AND $city AND poolips.type LIKE '".$base."_' ".
+        "GROUP BY pool");
     $sth->execute;
-    my %ipcount;
     my $optionlist;
     while (my @data = $sth->fetchrow_array) {
-      $ipcount{$data[0]}++;
-    }
-    $sth = $ip_dbh->prepare("select city from allocations where cidr=?");
-    foreach my $key (keys %ipcount) {
-      $sth->execute($key);
-      my @data = $sth->fetchrow_array;
-      $optionlist .= "<option value='$key'>$key [$ipcount{$key} free IP(s)] in $data[0]</option>\n";
+      # city,pool cidr,free IP count
+      if ($data[2] > 0) {
+        $optionlist .= "<option value='$data[1]'>$data[1] [$data[2] free IP(s)] in $data[0]</option>\n";
+      }
     }
     $cidr = "Single static IP";
@@ -880 +876 @@
 ##fixme
 # This section needs serious Pondering.
-        # Pools of all types get assigned to the POP they're "routed from"
+        # Pools of most types get assigned to the POP they're "routed from"
         # This includes WAN blocks and other netblock "containers"
-        if ($webvar{alloctype} =~ /^.[pdc]$/) {
+        # This does NOT include cable pools.
+        if ($webvar{alloctype} =~ /^.[pc]$/) {
           if (($webvar{city} !~ /^(Sudbury|North Bay|Toronto)$/) && ($webvar{alloctype} eq 'dp')) {
             printError("You must chose Sudbury, North Bay, or Toronto for DSL pools.");