Changeset 548

Timestamp:

11/08/12 17:57:54 (11 years ago)

Author:

Kris Deugau

Message:

/trunk

Clean up another couple of syntax-mess warnings. See #31.

File:

• trunk/cgi-bin/admin.cgi (modified) (4 diffs)

trunk/cgi-bin/admin.cgi

@@ -69 +69 @@
 }
 
+if(!defined($webvar{action})) {
+  $webvar{action} = "main";   #shuts up the warnings.
+}
+
 # handle DB error output
 if ($webvar{action} eq 'dberr') {
@@ -87 +91 @@
 
 my $header = HTML::Template->new(filename => "admin/header.tmpl");
-
-if(!defined($webvar{action})) {
-  $webvar{action} = "main";   #shuts up the warnings.
-}
 
 my $page;
@@ -567 +567 @@
 # List all IPs in a pool, and allow arbitrary admin changes to each
 # Allow changes to ALL fields
-sub showPool($) {
+sub showPool {
   my $pool = new NetAddr::IP $_[0];
 
@@ -582 +582 @@
   $page->param(typelist => \@typelist);
 
-  $sth = $ip_dbh->prepare("select ip,custid,city,type,available,description,notes from poolips where pool='$pool' order by ip");
-  $sth->execute;
+  $sth = $ip_dbh->prepare("SELECT ip,custid,city,type,available,description,notes from poolips".
+        " WHERE pool=? ORDER BY ip");
+  $sth->execute($pool);
   my @iplist;
   while (my ($ip,$custid,$city,$type,$avail,$desc,$notes) = $sth->fetchrow_array) {