Changeset 72

Timestamp:

11/15/04 16:53:24 (20 years ago)

Author:

Kris Deugau

Message:

/trunk

Fixed checks for static-ip allocation types. Really. For sure.

File:

• trunk/cgi-bin/main.cgi (modified) (17 diffs)

trunk/cgi-bin/main.cgi

@@ -356 +356 @@
     # Fix up types from pools (which are single-char)
     # Fixing the database would be...  painful.  :(
-    if ($data[2] =~ /^[sdcmw]$/) {
+    if ($data[2] =~ /^[cdsmw]$/) {
       $data[2] .= 'i';
     }
@@ -362 +362 @@
         $data[1], $full_alloc_types{$data[2]}, $data[3], $data[4]);
     # Allow listing of pool if desired/required.
-    if ($data[2] =~ /^[sdcmw]p$/) {
+    if ($data[2] =~ /^[cdsmw]p$/) {
       $row[0] .= ' &nbsp; <a href="/ip/cgi-bin/main.cgi?action=listpool'.
         "&pool=$data[0]\">List IPs</a>";
@@ -651 +651 @@
         $data[3], $full_alloc_types{$data[2]}, $data[1], $data[4]);
     # If the allocation is a pool, allow listing of the IPs in the pool.
-    if ($data[2] =~ /^[sdcmw]p$/) {
+    if ($data[2] =~ /^[cdsmw]p$/) {
       $row[0] .= ' &nbsp; <a href="/ip/cgi-bin/main.cgi?action=listpool'.
         "&pool=$data[0]\">List IPs</a>";
@@ -814 +814 @@
 #  + Different flavours of netblock
 
-  if ($webvar{alloctype} =~ /^[scdmw]i$/) {
+  if ($webvar{alloctype} =~ /^[cdsmw]i$/) {
     my ($base,undef) = split //, $webvar{alloctype};    # split into individual chars
     my $sql;
@@ -870 +870 @@
           " a set of smaller netblocks or a single smaller netblock.";
       } else {
-        if ($webvar{alloctype} =~ /^[scdmw]p$/) {
+        if ($webvar{alloctype} =~ /^[cdsmw]p$/) {
           if (($webvar{city} !~ /^(Sudbury|North Bay)$/) && ($webvar{alloctype} eq 'dp')) {
             printAndExit("You must chose Sudbury or North Bay for DSL pools."); }
@@ -912 +912 @@
       $cidr = $subblocks[0];
     }
-  } # if ($webvar{alloctype} =~ /^[cdsm]i$/) {
+  } # if ($webvar{alloctype} =~ /^[cdsmw]i$/)
 
   open HTML, "../confirm.html"
@@ -964 +964 @@
 # Same ordering as confirmation page
 
-  if ($webvar{alloctype} =~ /^[scdmw]i$/) {
+  if ($webvar{alloctype} =~ /^[cdsmw]i$/) {
     my ($base,$tmp) = split //, $webvar{alloctype};     # split into individual chars
 
@@ -1114 +1114 @@
       # special extra handling for pools.
       # Note that this must be done for ANY pool allocation!
-      if ( my ($pooltype) = ($webvar{alloctype} =~ /^([cdsm])p$/) ) {
+      if ( my ($pooltype) = ($webvar{alloctype} =~ /^([cdsmw])p$/) ) {
         # have to insert all pool IPs into poolips table as "unallocated".
         $sth = $ip_dbh->prepare("insert into poolips values ('$webvar{fullcidr}',".
@@ -1158 +1158 @@
     }
     print "<!-- [ In validateInput().  Insert customer ID cross-check here. ] -->\n";
-  } elsif ($webvar{alloctype} =~ /^([sdcmw]p|si|dn|dy|dc|ee|rr|ii)$/){
+  } elsif ($webvar{alloctype} =~ /^([cdsmw]p|si|dn|dy|dc|ee|rr|ii)$/){
     # All non-customer allocations MUST be entered with "our" customer ID.
     # I have Defined this as 6750400 for consistency.
@@ -1204 +1204 @@
 
   # Postfix "i" on pool IP types
-  if ($data[2] =~ /^[cdsm]$/) {
+  if ($data[2] =~ /^[cdsmw]$/) {
     $data[2] .= "i";
   }
@@ -1264 +1264 @@
     # Relatively simple SQL transaction here.
     my $sql;
-    if (my $pooltype = ($webvar{alloctype} =~ /^([cdms])i$/) ) {
+    if (my $pooltype = ($webvar{alloctype} =~ /^([cdsmw])i$/) ) {
       $sql = "update poolips set custid='$webvar{custid}',".
         "notes='$webvar{notes}',description='$webvar{desc}' ".
@@ -1344 +1344 @@
     $desc = "N/A";
     $notes = "N/A";
-  } elsif ($webvar{alloctype} =~ /^[sdcmw]i$/) { # done with alloctype=rr
+  } elsif ($webvar{alloctype} =~ /^[cdsmw]i$/) { # done with alloctype=rr
 
     # Unassigning a static IP
@@ -1357 +1357 @@
     $alloctype .="i";
 
-  } else { # done with alloctype=[sdcmw]i
+  } else { # done with alloctype=[cdsmw]i
 
     my $sth = $ip_dbh->prepare("select cidr,custid,type,city,description,notes from ".
@@ -1381 +1381 @@
 
   # Set the warning text.
-  if ($alloctype =~ /^[sdcmw]p$/) {
+  if ($alloctype =~ /^[cdsmw]p$/) {
     $html =~ s|<!--warn-->|<tr bgcolor="black"><td colspan="2"><div class="red">Warning: clicking confirm will remove this record entirely.<br>Any IPs allocated from this pool will also be removed!</div></td></tr>|;
   } else {
@@ -1403 +1403 @@
   local $ip_dbh->{RaiseError} = 1;
 
-  if ($webvar{alloctype} =~ /^[sdcmw]i$/) {
+  if ($webvar{alloctype} =~ /^[cdsmw]i$/) {
 
     eval {
@@ -1426 +1426 @@
     syslog "notice", "$authuser deallocated static IP $webvar{block}";
 
-  } elsif ($webvar{alloctype} eq 'mm') { # end alloctype = [sdcmw]i
+  } elsif ($webvar{alloctype} eq 'mm') { # end alloctype = [cdsmw]i
 
     eval {
@@ -1471 +1471 @@
         $sth->execute;
         # Special case - delete pool IPs
-        if ($webvar{alloctype} =~ /^[sdcmw]p$/) {
+        if ($webvar{alloctype} =~ /^[cdsmw]p$/) {
           # We have to delete the IPs from the pool listing.
           $sth = $ip_dbh->prepare("delete from poolips where pool='$webvar{block}'");