Changeset 733 for trunk/cgi-bin

Timestamp:

05/25/15 18:25:20 (10 years ago)

Author:

Kris Deugau

Message:

/trunk

Cleanup while rechecking merge-to-container in UI:

• Move descriptive strings for merge scopes into a hash in IPDB.pm, so we don't have to update them everywhere every time they might change... now that most of the changes are done, of course.
• Refiddle listForMerge's freeblock branch to show only direct children, or all free blocks depending on another optional argument.
• Render previous point pointless due to dropping freeblocks from the return list of merged blocks anyway, because Confusion.
• Force scope as well as type when merging a master block. Merging any other type in a way that happens to intersect a master remains undefined.
• Make sure to capture the blocks merged/deleted for return.
• Fix up some variable names for consistency.
• Fix stupid typo missed in r732.

See #8.

Location:

trunk/cgi-bin

Files:

• IPDB.pm (modified) (13 diffs)
• main.cgi (modified) (2 diffs)

trunk/cgi-bin/IPDB.pm

@@ -25 +25 @@
 @EXPORT_OK    = qw(
         %disp_alloctypes %list_alloctypes %def_custids @citylist @poplist
-        %IPDBacl %aclmsg %rpcacl $maxfcgi
+        %IPDBacl %merge_display %aclmsg %rpcacl $maxfcgi
         $errstr
         &initIPDBGlobals &connectDB &finish &checkDBSanity
@@ -41 +41 @@
 %EXPORT_TAGS    = ( ALL => [qw(
                 %disp_alloctypes %list_alloctypes %def_custids @citylist @poplist
-                %IPDBacl %aclmsg %rpcacl $maxfcgi
+                %IPDBacl %merge_display %aclmsg %rpcacl $maxfcgi
                 $errstr
                 &initIPDBGlobals &connectDB &finish &checkDBSanity
@@ -67 +67 @@
 # Mapping hash for pooltype -> poolip-as-netblock conversions
 my %poolmap = (sd => 'en', cd => 'cn', dp => 'cn', mp => 'cn', wp => 'cn', ld => 'in', ad => 'in', bd => 'in');
+
+# Friendly display strings for merge scopes
+our %merge_display = (
+        keepall   => "Keep mergeable allocations as suballocations of new block",
+        mergepeer => "Keep suballocations of mergeable allocations",
+        clearpeer => "Keep only suballocations of the selected block",
+        clearall  => "Clear all suballocations"
+        );
 
 # mapping table for functional-area => error message
@@ -916 +924 @@
   my $btype = shift || 'a';
   $btype = 'a' if $btype !~/^[af]$/;
+  my $incsub = shift;
+  $incsub = 1 if !defined($incsub);
 
   my $sql;
@@ -929 +939 @@
   } else {
 ##fixme:  Not sure about the casting hackery in "SELECT ?::integer AS id", but it works as intended
-    my $ret = $dbh->selectall_arrayref(q(
-        SELECT cidr,id FROM freeblocks
-        WHERE parent_id IN (SELECT ?::integer AS id UNION
-                SELECT id FROM allocations WHERE parent_id = ? AND cidr <<= ?
-        ) AND cidr <<= ?
-        ORDER BY cidr
-        ),
-        { Slice => {} }, $parent, $parent, $newblock, $newblock) or print $dbh->errstr;
+    my @dbargs = ($parent, "$newblock");
+    push @dbargs, $parent, $newblock if $incsub;
+    my $ret = $dbh->selectall_arrayref(q{
+        SELECT cidr,id FROM freeblocks
+        WHERE parent_id IN (
+      }.($incsub ? "SELECT id FROM allocations WHERE parent_id = ? AND cidr <<= ? UNION " : '').q{
+                SELECT ?::integer AS id
+            ) AND cidr <<= ?
+        ORDER BY cidr
+      },
+        { Slice => {} }, @dbargs);
     return $ret;
   }
+  return;
 } # end listForMerge()
 
@@ -2003 +2017 @@
 # Takes a "base" block ID and a hash with a mask length and a scope argument to decide
 # how much existing allocation data to delete.
+# Returns a list starting with the new merged block, then the merged allocations with comment
 ## Merge scope:
 # Merge to container
@@ -2064 +2079 @@
   $args{newtype} = $binfo->{type} if !$args{newtype};
   # if the "primary" block being changed is a master, it must remain one.
-  $args{newtype} = 'mm' if $binfo->{type} eq 'mm';
+  # Also force the scope, since otherwise things get ugly.
+  if ($binfo->{type} eq 'mm') {
+    $args{newtype} = 'mm';
+    # don't want to make a peer master a sub of the existing one;  too many special cases go explodey,
+    # but want to retain all other allocations
+    $args{scope} = 'mergepeer';
+  }
   my ($newcontainerclass) = ($args{newtype} =~ /^(.).$/);
 
@@ -2123 +2144 @@
       ## Container
 
-      # In case of merging a master block
+      # In case of merging a master block.  Somewhat redundant with calls to $fbreparentsth,
+      # but not *quite* entirely.
       my $mfbsth = $dbh->prepare("UPDATE freeblocks SET master_id = ? WHERE master_id = ?");
 
@@ -2131 +2153 @@
         # and now retrieve the new parent ID
         ($prime) = $dbh->selectrow_array("SELECT currval('allocations_id_seq')");
+        # snag the new parent info for the return list
+        push @retlist, { block => "$newblock", type => $disp_alloctypes{$args{newtype}}, id => $prime };
         # Reparent the free blocks in the new block
         $fbreparentsth->execute($prime, $binfo->{master_id}, $binfo->{city}, $newcontainerclass, $binfo->{vrf},
             $binfo->{parent_id}, $newblock);
         # keep existing allocations (including the original primary), just push them down a level
-        while (my ($pcidr,$peer_id,$ptype,$m_id) = $peersth->fetchrow_array) {
+        while (my ($peercidr, $peer_id, $peertype, $m_id) = $peersth->fetchrow_array) {
           $reparentsth->execute($prime, $binfo->{master_id}, $peer_id);
           # Fix up master_id on free blocks if we're merging a master block
-          $mfbsth->execute($binfo->{master_id}, $m_id) if $ptype eq 'mm';
+          $mfbsth->execute($binfo->{master_id}, $m_id) if $peertype eq 'mm';
+          # capture block for return
+          push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
         }
 
       } elsif ($args{scope} =~ /^clear/) {
         # clearpeer and clearall share a starting point
+        # snag the new parent info for the return list
+        push @retlist, { block => "$newblock", type => $disp_alloctypes{$args{newtype}}, id => $prime };
         # update the primary allocation info
         $dbh->do("UPDATE allocations SET cidr = ?, type = ? WHERE id = ?", undef, ($newblock, $args{newtype}, $prime) );
@@ -2153 +2181 @@
               $binfo->{master_id});
         }
-        # delete the peers
-        while (my ($pcidr,$peer_id) = $peersth->fetchrow_array) {
+        # delete the peers.
+        while (my ($peercidr, $peer_id, $peertype, $m_id) = $peersth->fetchrow_array) {
           next if $peer_id == $prime;
           # push existing allocations down a level before deleting,
@@ -2163 +2191 @@
           # aren't special cases fun?
           $dbh->do("INSERT INTO freeblocks (cidr,routed,parent_id,master_id) values (?,?,?,?)",
-                undef, ($pcidr, 'm', $prime, $prime) ) if $binfo->{type} eq 'mm';
+              undef, ($peercidr, 'm', $prime, $prime) ) if $binfo->{type} eq 'mm';
+          # capture block for return
+          push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
         }
         if ($args{scope} eq 'clearall') {
@@ -2182 +2212 @@
       } elsif ($args{scope} eq 'mergepeer') { # should this just be an else?
         # Default case.  Merge "peer" blocks, but keep all suballocations
+        # snag the new parent info for the return list
+        push @retlist, {block => "$newblock", type => $disp_alloctypes{$args{newtype}}, id => $prime};
         my $substh = $dbh->prepare("UPDATE allocations SET parent_id = ? WHERE parent_id = ?");
         my $delsth = $dbh->prepare("DELETE FROM allocations WHERE id = ?");
@@ -2202 +2234 @@
               $binfo->{master_id}) if $peertype =~ /.[enr]/;
           # Convert pool IPs into allocations or aggregated free blocks
-          _poolToAllocations($dbh, $peerfull, $pinfo, newparent => $prime) if $peertype =~ /.[dp];
+          _poolToAllocations($dbh, $peerfull, $pinfo, newparent => $prime) if $peertype =~ /.[dp]/;
           # Fix up master_id on free blocks if we're merging a master block
           $mfbsth->execute($binfo->{master_id}, $m_id) if $peertype eq 'mm';
+          # capture block for return
+          push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
         } # merge peers
         # update the primary allocation info.  Do this last so we don't stomp extra data-retrieval in the loop above

trunk/cgi-bin/main.cgi

@@ -1221 +1221 @@
   $page->param(typelist => getTypeList($ip_dbh, 'n', $binfo->{type}));  # down the rabbit hole we go...
 
+  # Strings for scope;  do this way so we don't have to edit them many places
+  $page->param(vis_keepall => $merge_display{keepall});
+  $page->param(vis_mergepeer => $merge_display{mergepeer});
+  $page->param(vis_clearpeer => $merge_display{clearpeer});
+  $page->param(vis_clearall => $merge_display{clearall});
+
   # Tree navigation
   my $crumbs = getBreadCrumbs($ip_dbh, $binfo->{parent_id});
@@ -1265 +1271 @@
   $page->param(mergefree => $fb_list);
 
-##fixme:  push this up the stack somewhere so the labels can be fed to the relevant templates when/as needed
-  # scope
-  my %merge_friendly = (
-        keepall   => "Keep mergeable allocations as suballocations of new block",
-        mergepeer => "Keep suballocations of mergeable allocations",
-        clearpeer => "Keep only suballocations of $binfo->{block}",
-        clearall  => "Clear all suballocations"
-    );
-  $page->param(vis_scope => $merge_friendly{$webvar{scope}});
+  $page->param(vis_scope => $merge_display{$webvar{scope}});
   $page->param(scope => $webvar{scope});
 } # confMerge()