Changeset 746 for trunk/cgi-bin

Timestamp:

06/16/15 17:56:30 (10 years ago)

Author:

Kris Deugau

Message:

/trunk

• Tweak header docucomment for brief description of scope arguments for mergeBlocks()
• Adjust return data structure in mergeBlocks() to match and propagate the change in _toPool() in r745. This is needed for properly handling a couple of branches of reverse DNS RPC calls. See #8.

File:

• trunk/cgi-bin/IPDB.pm (modified) (9 diffs)

trunk/cgi-bin/IPDB.pm

@@ -2137 +2137 @@
 #     Convert leaf allocations into free blocks.
 #   clearpeer
-#     Keep subs of the original
-#     Convert assigned IPs from pools into subs.
-#     Convert unused IPs from pools into free blocks.
-#     Convert leaf allocations into free blocks.
+#     Keep subs of the original (if it was a container).
+#     Convert assigned IPs from the original pool into subs (if it was a pool).
+#     Convert unused IPs from the original pool into free blocks (if it was a pool).
+#     Delete all peers and their subs aside from the original.
 #   clearall
 #     Delete all peers, subs and IPs.
@@ -2272 +2272 @@
           $mfbsth->execute($binfo->{master_id}, $m_id) if $peertype eq 'mm';
           # capture block for return
-          push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
+          push @retlist, { block => $peercidr, mdisp => $disp_alloctypes{$peertype}, mtype => $peertype };
         }
 
@@ -2301 +2301 @@
               undef, ($peercidr, 'm', $prime, $prime) ) if $binfo->{type} eq 'mm';
           # capture block for return
-          push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
+          push @retlist, { block => $peercidr, mdisp => $disp_alloctypes{$peertype}, mtype => $peertype };
         }
         if ($args{scope} eq 'clearall') {
@@ -2346 +2346 @@
           $mfbsth->execute($binfo->{master_id}, $m_id) if $peertype eq 'mm';
           # capture block for return
-          push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
+          push @retlist, { block => $peercidr, mdisp => $disp_alloctypes{$peertype}, mtype => $peertype };
         } # merge peers
         # update the primary allocation info.  Do this last so we don't stomp extra data-retrieval in the loop above
@@ -2363 +2363 @@
       if ($args{scope} eq 'keepall') {
         # Convert all mergeable allocations and subs to chunks of pool IP assignments
-        push @retlist, @{ _toPool($dbh, $prime, $newblock, $args{newtype}) };
+        push @retlist, @{ _toPool($dbh, $prime, $newblock, $args{newtype}, 1) };
 
       } elsif ($args{scope} =~ /^clear/) {
@@ -2374 +2374 @@
           _deleteCascade($dbh, $peer_id, 0);
           # Capture block for return
-          push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
+          push @retlist, { block => $peercidr, mdisp => $disp_alloctypes{$peertype}, mtype => $peertype };
         }
         if ($args{scope} eq 'clearall') {
@@ -2385 +2385 @@
         } else {
           # Convert (subs of) self if not a leaf.
-          _toPool($dbh, $prime, $newblock, $args{newtype}) unless $binfo->{type} =~ /.[enr]/;
+          push @retlist, @{ _toPool($dbh, $prime, $newblock, $args{newtype}, 1) }
+              unless $binfo->{type} =~ /.[enr]/;
         } # scope ne 'clearall'
 
@@ -2393 +2394 @@
           next if $peer_id == $prime;  # don't delete the block we're turning into the pool allocation
           # Capture block for return
-          push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
+          push @retlist, { block => $peercidr, mdisp => $disp_alloctypes{$peertype}, mtype => $peertype };
           next unless $peertype =~ /.[enr]/;
           # Don't need _deleteCascade(), since we'll just be deleting the freshly
@@ -2424 +2425 @@
         _deleteCascade($dbh, $peer_id, 0);
         # Capture block for return
-        push @retlist, { block => $peercidr, mtype => $disp_alloctypes{$peertype} };
+        push @retlist, { block => $peercidr, mdisp => $disp_alloctypes{$peertype}, mtype => $peertype };
       }
       # Delete any subs of $prime as well