Changeset 787 for trunk/cgi-bin


Ignore:
Timestamp:
10/08/15 17:41:56 (9 years ago)
Author:
Kris Deugau
Message:

/trunk

Fix lurking error display/logging/notification bug. Update confirmation
or error reporting didn't get updated to match the processing, and was
reporting the allocation ID (which used to be the CIDR).

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/cgi-bin/main.cgi

    r786 r787  
    11321132
    11331133  if ($code eq 'FAIL') {
    1134     syslog "err", "$authuser could not update block/IP '$webvar{block}': '$msg'";
    1135     $page->param(err => "Could not update block/IP $webvar{block}: $msg");
     1134    syslog "err", "$authuser could not update block/IP '$binfo->{block}' (id $webvar{block}): '$msg'";
     1135    $page->param(err => "Could not update block/IP $binfo->{block}: $msg");
    11361136    return;
    11371137  }
    11381138
    11391139  # If we get here, the operation succeeded.
    1140   syslog "notice", "$authuser updated $webvar{block}";
     1140  syslog "notice", "$authuser updated $binfo->{block}";
    11411141##fixme:  log details of the change?  old way is in the .debug stream anyway.
    11421142##fixme:  need to wedge something in to allow "update:field" notifications
    11431143## hmm.  how to tell what changed?  O_o
    1144 mailNotify($ip_dbh, 's:swi', "SWIPed: $disp_alloctypes{$webvar{alloctype}} $webvar{block}",
    1145         "$webvar{block} had SWIP status changed to \"Yes\" by $authuser") if $webvar{swip} eq 'on';
     1144mailNotify($ip_dbh, 's:swi', "SWIPed: $disp_alloctypes{$webvar{alloctype}} $binfo->{block}",
     1145        "$binfo->{block} had SWIP status changed to \"Yes\" by $authuser") if $webvar{swip} eq 'on';
    11461146
    11471147## node hack
Note: See TracChangeset for help on using the changeset viewer.