Changeset 902 for trunk

Timestamp:

02/15/17 14:15:32 (8 years ago)

Author:

Kris Deugau

Message:

/trunk

First pass safety fence to help prevent "missing" forward records. If a
DNS entry is passed as an unqualified name, the A part of the A+PTR
metarecord gets dropped since there will be no match in the domain list.

This adds a setting, defaulting to enabled, to append the default domain
to unqualified names in the main rDNS field on add and update.

Location:

trunk/cgi-bin

Files:

• IPDB.pm (modified) (3 diffs)
• MyIPDB.pm (modified) (1 diff)

trunk/cgi-bin/IPDB.pm

@@ -139 +139 @@
 # Billing system return link
 our $billinglink = 'https://billing.example.com/radius.pl';
+
+# Append the default domain on unqualified DNS names?
+our $append_domain = 1;
 
 ##
@@ -1551 +1554 @@
   $args{rdns} = '' if !$args{rdns};
 
+  # munge the reverse name to include the default domain if there are no dots.  Don't append if
+  # there's no DNS argument though, that would likely cause Big Problems
+  $args{rdns} .= ".$IPDB::domain" if $IPDB::append_domain && $args{rdns} && $args{rdns} !~ /\./;
+
   $args{user} = $args{rpcuser} if !$args{user};
 
@@ -2099 +2106 @@
   # Return early if rDNS flag(s) are not set
   return ('OK','OK') unless ($pinfo->{revavail} || $pinfo->{revpartial});
+
+  # munge the reverse name to include the default domain if there are no dots.  Don't append if
+  # there's no DNS argument though, that would likely cause Big Problems
+  $args{rdns} .= ".$IPDB::domain" if $IPDB::append_domain && $args{rdns} && $args{rdns} !~ /\./;
 
   # In case of any container (mainly master block), only update freeblocks so we don't stomp subs

trunk/cgi-bin/MyIPDB.pm

@@ -97 +97 @@
 #$IPDB::billinglink = 'https://billing.example.com/radius.pl';
 
+## Append default domain to unqualified DNS names?  (ie, names without dots)
+# Disabling this can result in DNS names that get "lost", due to downconversion from A+PTR to PTR.  
+#$IPDB::append_domain = 1;
+
 ## connectDB_My()
 # Wrapper for IPDB::connectDB