Changeset 101 for trunk/dns.cgi

Timestamp:

07/06/11 17:17:46 (14 years ago)

Author:

Kris Deugau

Message:

/trunk

dns.cgi:

Prefill <domain> or DOMAIN in Hostname field on add record page
Set initial TTL correctly based on SOA record rather than hardcoded defaults

DNSDB.pm:

Tweak retrieval code to pull SOA's serial from distance field

File:

• trunk/dns.cgi (modified) (4 diffs)

trunk/dns.cgi

@@ -37 +37 @@
 
 my @debugbits;  # temp, to be spit out near the end of processing
-my $debugenv = 1;
+my $debugenv = 0;
 
 # Let's do these templates right...
@@ -1269 +1269 @@
   no warnings qw( uninitialized );
 
-  $page->param(name     => $webvar{name});
+##todo:  allow BIND-style bare names, ASS-U-ME that the name is within the domain?
+# prefill <domain> or DOMAIN in "Host" space for new records
+  my $domroot = ($webvar{defrec} eq 'y' ? 'DOMAIN' : domainName($dbh,$webvar{parentid}));
+  $page->param(name     => $domroot);
   $page->param(address  => $webvar{address});
   $page->param(distance => $webvar{distance})
@@ -1275 +1278 @@
   $page->param(weight   => $webvar{weight}) if $webvar{type} == $reverse_typemap{SRV};
   $page->param(port     => $webvar{port}) if $webvar{type} == $reverse_typemap{SRV};
-  $page->param(ttl      => ($webvar{ttl} ? $webvar{ttl} : $DNSDB::def{minttl}));
+# retrieve the right ttl instead of falling (way) back to the hardcoded system default
+  my %soa = getSOA($dbh,$webvar{defrec},$webvar{parentid});
+  $page->param(ttl      => ($webvar{ttl} ? $webvar{ttl} : $soa{minttl}));
 }
 
@@ -1677 +1682 @@
 
 ##fixme: push SQL into DNSDB.pm
+##fixme: add bits to retrieve group/domain name info to retain after entity is deleted?
   my $sth = $dbh->prepare("SELECT user_id, firstname || ' ' || lastname FROM users WHERE username=?");
   $sth->execute($username);