Changeset 1018 for branches/cname-collision/DNSDB.pm

Timestamp:

02/05/26 12:24:47 (3 days ago)

Author:

Kris Deugau

Message:

/branches/cname-collision

Refine one subbranch of the collision check logic; while in general an
expiring record can have its expiry time coerced to match a conflicting
valid-after record, it makes little sense to allow adding a record that
expires in the past to match a valid-after record with a timestamp in the
past.

The inverse case of a new/updated valid-after record conflicting with an
expired record with a timestamp in the past at least makes sense to allow
as the new record will be active immediately.

See #72

File:

• branches/cname-collision/DNSDB.pm (modified) (1 diff)

branches/cname-collision/DNSDB.pm

@@ -729 +729 @@
         } else {
           if ($self->{coerce_cname_timestamp} eq 'adjust') {
-            # coerce the valid-after timestamp
-            ${$args{stamp}} = strftime('%Y-%m-%d %H:%M:%S', localtime($t[0]));
-            return ('WARN', $typemap{${$args{rectype}}}." ".($args{update} ? 'updated' : 'added').
+            if ($t[2] == 1) {
+              # found a valid-after, but it's in the past, so adding an expiring record to match doesn't make
+              # sense since it's effectively expired.
+##fixme:  should probably remove this case once we get around to stripping valid-after timestamps once exported as active
+              return ('FAIL', "Cannot ".($args{update} ? 'update' : 'add')." ".$typemap{${$args{rectype}}}.
+                ", an existing valid-after record is already active for this name");
+            } else {
+              # coerce the expiry timestamp
+              ${$args{stamp}} = strftime('%Y-%m-%d %H:%M:%S', localtime($t[0]));
+              return ('WARN', $typemap{${$args{rectype}}}." ".($args{update} ? 'updated' : 'added').
                 " with modified valid-after time;  conflicting expiring record found");
+            }
           } else {
             # New valid-after overlaps existing expiry, and not configured to adjust it