Changeset 1039 for branches/cname-collision/DNSDB.pm

Timestamp:

02/17/26 14:02:32 (13 hours ago)

Author:

Kris Deugau

Message:

/branches/cname-collision

Clean up some miscellanea found preparing to merge this branch back to /trunk

File:

• branches/cname-collision/DNSDB.pm (modified) (7 diffs)

branches/cname-collision/DNSDB.pm

@@ -626 +626 @@
 
   my %args = @_;
-#my ($hcheck,$rectype,$zid,$defrec,$revrec) = @_;
 
   my $hcheck = ($args{revrec} eq 'y' ? ${$args{val}} : ${$args{host}});
   my $hfield = ($args{revrec} eq 'y' ? 'val' : 'host');
-#my $hcheck = $hname;
 
   # $hcheck should be normalized by the time this sub is called.  Convert to the formal .arpa name for error reporting in reverse zones.
@@ -640 +638 @@
   }
 
-#  my $ret = 'OK';
-#  my $msg = 'OK';
-
   # The record type comparison is the only difference between two passes through this chunk of code.
   # CNAME records require both passes, where other records only need the second one.  Downside is
@@ -649 +644 @@
     next if $tcompare eq '<>' && ${$args{rectype}} != 5;
 
-# Merging these sets of SQL statements is far too messy and doesn't reasonably
-# allow for more fine-grained error/warning messages to be returned
+    # Merging these sets of SQL statements is far too messy and doesn't reasonably
+    # allow for more fine-grained error/warning messages to be returned
 
     # First lookup fails out collisions with records without timestamps or default records (which can not have timestamps)
@@ -840 +835 @@
     return ('FAIL',"A record must be a valid IPv4 address")
         unless $args{addr} && !$args{addr}->{isv6};
-
     # coerce IP/value to normalized form for storage
     ${$args{val}} = $args{addr}->addr;
@@ -966 +960 @@
       # Enforce this for the zone name
       return ('FAIL', "The bare zone name may not be a CNAME") if ${$args{host}} eq $pname || ${$args{host}} =~ /^\@/;
-
-#      # Check for hostnames matching new name
-#      my @t = $dbh->selectrow_array("SELECT count(*) FROM records WHERE domain_id = ? AND type <> ? AND host = ?",
-#       undef, $args{id}, 5, ${$args{host}});
-#      return ('FAIL', "One or more existing records already use ${$args{host}}.  CNAME records cannot use the same name as other records.")
-#       if $t[0] > 0;
 
       return ('FAIL', $errstr) if ! _check_hostname_form(${$args{val}}, ${$args{rectype}}, $args{defrec}, $args{revrec});
@@ -1778 +1766 @@
     return ('FAIL',"Delegation records are not permitted in default record sets");
   }
-
   return ('OK','OK');
 } # done delegation record
@@ -2387 +2374 @@
       $cfg->{force_refresh}     = $1 if /^force_refresh\s*=\s*([a-z01]+)/i;
       $cfg->{lowercase}         = $1 if /^lowercase\s*=\s*([a-z01]+)/i;
-      $cfg->{coerce_cname_timestamp}    = $1 if /^coerce_cname_timestamp\s*=\s*(full|adjust|none)\s*$/i;
       $cfg->{showrev_arpa}      = $1 if /^showrev_arpa\s*=\s*([a-z]+)/i;
       $cfg->{coerce_cname_timestamp}    = $1 if /^coerce_cname_timestamp\s*=\s*([a-z]+)/i;