Changeset 1044 for branches/cname-collision/t/cname.t

Timestamp:

02/20/26 13:37:06 (18 hours ago)

Author:

Kris Deugau

Message:

/branches/cname-collision

Complete a missed conversion from ok() to cmp_ok()
A couple more docucomments
See #88

File:

• branches/cname-collision/t/cname.t (modified) (3 diffs)

branches/cname-collision/t/cname.t

@@ -313 +313 @@
       $newname = 'expires-at5.expiry2.test';
       ($code, $msg) = $dnsdb->addRec('n', 'n', 5, \$newname, \$rectype, \$newval, 900, undef, 't', $expirystamp);
-      ok( $code, 'eq', 'FAIL', "addRec() claimed failure" );
+      cmp_ok( $code, 'eq', 'FAIL', "addRec() claimed failure" );
       if ($code eq 'FAIL') {
         ($rcount) = $dbh->selectrow_array("SELECT count(*) FROM records WHERE domain_id = 5 AND host = '$newname'");
@@ -387 +387 @@
   }; # add valid-after CNAME
 
-  ## Tests calling updateRec() instead of addRec()
-  subtest 'Update to CNAME - no timestamp' => sub {
+  ## Update a record to a CNAME or update an existing CNAME (no difference in handling
+  ## - to misquote Rincewind, "Don't worry about from ... The important word is to.")
+  ## Update to CNAME with no timestamp
+ subtest 'Update to CNAME - no timestamp' => sub {
     $newval = 'target.example.com';
     subtest 'collision with expired record' => sub {
@@ -432 +434 @@
   }; # update to CNAME with no timestamp
 
+  ## Update to CNAME with expiry
   subtest 'CNAME update - expires soon' => sub {
     my @ltime = localtime(time + 86400 * 3);