Changeset 248 for trunk/dns.cgi

Timestamp:

02/28/12 17:11:56 (13 years ago)

Author:

Kris Deugau

Message:

/trunk

Quick pass over log linking and display for reverse zones. See #26.
Also add a ##fixme in logaction() for pagination, filtering, and
other log data massaging.

Fix a couple of typos introduced by hand-applying unrelated fixes
in a separate working copy

File:

• trunk/dns.cgi (modified) (5 diffs)

trunk/dns.cgi

@@ -493 +493 @@
     $page->param(defrec => $webvar{defrec});
     showzone($webvar{defrec}, $webvar{revrec}, $webvar{id});
-    if ($webvar{defrec} eq 'y') {
-    } else {
+    if ($webvar{defrec} eq 'n') {
 #      showzone('n',$webvar{id});
 ##fixme:  permission for viewing logs?
 ##fixme:  determine which slice of the log we view (group, domain, revzone)
-      $page->param(logdom => 1);
+      if ($webvar{revrec} eq 'n') {
+        $page->param(logdom => 1);
+      } else {
+        $page->param(logrdns => 1);
+      }
     }
 
@@ -523 +526 @@
   # security check - does the user have permission to access this entity?
   if (!check_scope(id => $webvar{id}, type =>
-        ($webvar{defrec} eq 'y' ? ($webvar{revrec eq 'y' ? 'defrevrec' : 'defrec') : 'record'))) {
+        ($webvar{defrec} eq 'y' ? ($webvar{revrec} eq 'y' ? 'defrevrec' : 'defrec') : 'record'))) {
     $page->param(perm_err => "You are not permitted to edit the requested record");
     goto DONEREC;
@@ -761 +764 @@
   # id is domain/revzone/group id
   if (!check_scope(id => $webvar{id}, type =>
-        ($webvar{defrec} eq 'y' ? 'group' : ($webvar{revrec} eq 'y' ? 'revzone' : 'domain'))) {
+        ($webvar{defrec} eq 'y' ? 'group' : ($webvar{revrec} eq 'y' ? 'revzone' : 'domain')))) {
     changepage(page => 'domlist', errmsg => "You do not have permission to edit the ".
         ($webvar{defrec} eq 'y' ? 'default ' : '')."SOA record for the requested ".
@@ -1597 +1600 @@
     }
     $page->param(logfor => 'domain '.domainName($dbh,$id));
+  } elsif ($webvar{ltype} && $webvar{ltype} eq 'rdns') {
+    $sql .= "rdns_id=?";
+    $id = $webvar{id};
+    if (!check_scope(id => $id, type => 'revzone')) {
+      $page->param(errmsg => "You are not permitted to view log entries for the requested reverse zone");
+      goto DONELOG;
+    }
+    $page->param(logfor => 'reverse zone '.revName($dbh,$id));
   } else {
     # Default to listing curgroup log
@@ -1604 +1615 @@
     # group log is always for the "current" group
   }
+##fixme:
+# - filtering
+# - show reverse zone column?
+# - pagination/limiting number of records - put newest-first so user
+#   doesn't always need to go to the last page for recent activity?
   my $sth = $dbh->prepare($sql);
   $sth->execute($id);