Changeset 510

Timestamp:

05/14/13 14:48:57 (12 years ago)

Author:

Kris Deugau

Message:

/trunk

Clear up some error-log garbage. See #25.

• don't try to redefine $defsort in getRecList
• set the hostname to in updateRec if it arrives undefined (the validation check a little later will trigger the actual error)

File:

• trunk/DNSDB.pm (modified) (2 diffs)

trunk/DNSDB.pm

@@ -3577 +3577 @@
   # protection against bad or missing arguments
   $args{sortorder} = 'ASC' if !$args{sortorder} || !grep /^$args{sortorder}$/, ('ASC','DESC');
-  my $defsort = 'host' if $args{revrec} eq 'n';     # default sort by host on domain record list
-  my $defsort = 'val' if $args{revrec} eq 'y';      # default sort by IP on revzone record list
+  my $defsort;
+  $defsort = 'host' if $args{revrec} eq 'n';     # default sort by host on domain record list
+  $defsort = 'val' if $args{revrec} eq 'y';      # default sort by IP on revzone record list
   $args{sortby} = $defsort if !$args{revrec};
   $args{sortby} = $defsort if $args{sortby} !~ /^[\w_.]+$/;
@@ -3808 +3809 @@
   my $location = shift; # may be empty/null/undef depending on caller
   $location  = '' if !$location;
+
+  # just set it to an empty string;  failures will be caught later.
+  $$host = '' if !$$host;
 
   # Spaces are evil.