Opened 8 years ago

Last modified 3 years ago

#25 new defect

(Ongoing) Clean up messes in the error log

Reported by: kdeugau Owned by:
Priority: minor Milestone:
Version: Keywords:
Cc:

Description

Reminder-to-self to check the error log for messy leftovers occasionally

Change History (17)

comment:1 Changed 8 years ago by kdeugau

(In [168]) /trunk

Fix a lurking error-log mess-dropper. See #25.

comment:2 Changed 8 years ago by kdeugau

(In [169]) /trunk

Fix another lurking error-log mess-maker when adding a record. See #25.

comment:3 Changed 7 years ago by kdeugau

(In [183]) /trunk

Fix minor error-log mess due to nonexistent username on login (see #25)

comment:4 Changed 7 years ago by kdeugau

(In [186]) /trunk

Add some more loop-breaking to isParent() to break infinite loops
that cause *big* messes in the error log (see #25)

  • just return 0 on parent == 0, 1 on child == 0
  • break the while() if the fetch returns no results, otherwise we end up trying to retrieve records for id=<undef>

comment:5 Changed 7 years ago by kdeugau

(In [205]) /trunk

Revert template tweak in r201 for clearing up a minor error log entry;
instead we'll set $webvar{makeactive} if it's not defined. See #25.

comment:6 Changed 7 years ago by kdeugau

(In [291]) /trunk

Fix minor error log mess due to possible nonexistent %webvar key
on group update. See #25

comment:7 Changed 7 years ago by kdeugau

(In [372]) /trunk

Checkpoint adding location/view support. See #10.

  • minor location list template tweak
  • extend importer to deal with locations on records, and location definitions
  • extend exporter to handle locations

Also:

  • minor SQL error-log cleanup (boolean types use 'y'/'n' or 'true'/'false'). See #25, sort of
  • Fix handling of CNAME exports for reverse zones; the records look ugly but there's no simple way to autoconvert them to the template types on import
  • Fix lurking buglet in tabledef update; we're using a 4-char field for locations to allow for legacy uses.

comment:8 Changed 6 years ago by kdeugau

(In [475]) /trunk

Fix a couple of error-log-polluters. See #25.

comment:9 Changed 6 years ago by kdeugau

(In [478]) /trunk

Another little error-log cleanup. See #25.

comment:10 Changed 6 years ago by kdeugau

(In [511]) /trunk

Clean up some error-log garbage in dns-rpc.cgi. See #25.

  • add a check sub to fail if defrec and revrec are not present; only called from subs that actually need them
  • include newlines in error-passback die() calls, so that we don't bother the caller with line numbers in dns-rpc.cgi

comment:11 Changed 6 years ago by kdeugau

(In [510]) /trunk

Clear up some error-log garbage. See #25.

  • don't try to redefine $defsort in getRecList
  • set the hostname to '' in updateRec if it arrives undefined (the validation check a little later will trigger the actual error)
Last edited 5 years ago by kdeugau (previous) (diff)

comment:12 Changed 6 years ago by kdeugau

(In [513]) /trunk

Get rid of another pair of minor messes in the error log. See #25.

  • sort of identify link-in or session-expired logins, so we don't try to redirect to the alternate login target when it's not necessary
  • set the sortby argument to '' in getRecList() if not defined. This may be worth tweaking further to account for default and/or reverse records.
Last edited 5 years ago by kdeugau (previous) (diff)

comment:13 Changed 5 years ago by kdeugau

(In [614]) /trunk

Bundle up several statements in getRecList() and getRecCount() inside an
if() block, since $args{filter} may or may not be defined, and when it's
not, it messes in the error log. See #25.

Also remove some stale, commented surrounding if/else fragments while we're
cleaning this up.

comment:14 Changed 5 years ago by kdeugau

(In [615]) /trunk

Correct r614 with the right function argument; getRecCount()'s arguments
are not quite identical to getRecList()'s. See #25.

comment:15 Changed 5 years ago by kdeugau

(In [658]) /trunk

Shave off another minor error log nuisance triggered by RPC netblock
adds. See #25.

comment:16 Changed 3 years ago by kdeugau

(In [705]) /trunk

Squash another bit of error-log-noise. See #25.

comment:17 Changed 3 years ago by kdeugau

(In [732]) /trunk

Fix minor warning exposed by log filtering. See #25.

Note: See TracTickets for help on using tickets.