Changeset 543 for trunk/dns-rpc.cgi

Timestamp:

12/10/13 16:22:10 (11 years ago)

Author:

Kris Deugau

Message:

/trunk

Implement most of the UI and back end for handling scheduled changes
to records. See #40.

This turned out to be most of what I had vaguely imagined; only SOA
records can't sanely be set for scheduled changes yet (can't think of
a scenario where this would even be useful) and there's only a small
dusting of UI chrome left for another time.

Bumped up from projected 1.4 to 1.2 per request from Reid Sutherland.

File:

• trunk/dns-rpc.cgi (modified) (3 diffs)

trunk/dns-rpc.cgi

@@ -475 +475 @@
 
   my @recargs = ($args{defrec}, $args{revrec}, $args{parent_id},
-        \$args{name}, \$args{type}, \$args{address}, $args{ttl}, $args{location});
+        \$args{name}, \$args{type}, \$args{address}, $args{ttl}, $args{location},
+        $args{expires}, $args{stamp});
   if ($args{type} == $DNSDB::reverse_typemap{MX} or $args{type} == $DNSDB::reverse_typemap{SRV}) {
     push @recargs, $args{distance};
@@ -497 +498 @@
   _reccheck(\%args);
 
+  # put some caller-friendly names in their rightful DB column places
+  $args{val} = $args{address};
+  $args{host} = $args{name};
+
   # get old line, so we can update only the bits that the caller passed to change
-  # note we subbed address for val since it's a little more caller-friendly
   my $oldrec = $dnsdb->getRecLine($args{defrec}, $args{revrec}, $args{id});
-  foreach my $field (qw(name type address ttl location distance weight port)) {
+  foreach my $field (qw(host type val ttl location expires distance weight port)) {
     $args{$field} = $oldrec->{$field} if !$args{$field} && defined($oldrec->{$field});
   }
+  # stamp has special handling when blank or 0.  "undefined" from the caller should mean "don't change"
+  $args{stamp} = $oldrec->{stamp} if !defined($args{stamp}) && defined($oldrec->{stamp});
 
   # allow passing text types rather than DNS integer IDs
@@ -510 +516 @@
   # parent_id is the "primary" zone we're updating;  necessary for forward/reverse voodoo
   my ($code, $msg) = $dnsdb->updateRec($args{defrec}, $args{revrec}, $args{id}, $args{parent_id},
-        \$args{name}, \$args{type}, \$args{address}, $args{ttl}, $args{location},
+        \$args{host}, \$args{type}, \$args{val}, $args{ttl}, $args{location},
+        $args{expires}, $args{stamp},
         $args{distance}, $args{weight}, $args{port});