Changeset 678 for trunk/dns-rpc.cgi

Timestamp:

01/22/15 18:27:21 (10 years ago)

Author:

Kris Deugau

Message:

/trunk

Fixes for edge-case updates via RPC:

• Replace call to $dnsdb->updateRec with rpc_UpdateRec in addOrUpdateRevRec to match the way arguments were being passed, and for consistency with the rest of the internal subcalls.
• Accept CIDR addresses, not just bare IPs, in updateRevSet; RPC is inexplicably slow so allowing batching of similar or mostly similar operations could speed things up a lot

File:

• trunk/dns-rpc.cgi (modified) (2 diffs)

trunk/dns-rpc.cgi

@@ -590 +590 @@
           # types are nominally impossible here.
           next unless $rec->{type} == 65282 || $rec->{type} == 65283 || $rec->{type} == 65284;
-          $dnsdb->updateRec(defrec =>'n', revrec => 'y', id => $rec->{record_id},
+          rpc_updateRec(defrec => 'n', revrec => 'y', id => $rec->{record_id},
             parent_id => $zdata->{rdns_id}, %args);
           last; # only do one record.
@@ -610 +610 @@
   # loop over passed IP/hostname pairs
   foreach my $key (keys %args) {
-    next unless $key =~ /^host_([\d.]+|[\da-f:]+)$/;
+    next unless $key =~ m{^host_((?:[\d.]+|[\da-f:]+)(?:/\d+)?)$};
     my $ip = $1;
     push @ret, addOrUpdateRevRec(cidr => $ip, name => $args{$key}, %args);