Changeset 687 for trunk/DNSDB.pm

Timestamp:

08/19/15 17:42:17 (9 years ago)

Author:

Kris Deugau

Message:

/trunk

Roll up a couple of typofixes and missing-argument handling reviewing
dns-rpc.cgi for documentation and testing:

• Fail early in DNSDB::delZone() if we didn't get a zone ID passed in
• Use the right argument name in dns-rpc.cgi:addDomain() for the domain's default location
• Fail early in dns-rpc.cgi:delZone() if we didn't get a zone ID
• Fix letterswap typo in dns-rpc.cgi:delRec() on revrec argument
• Add a bit more safety net in dns-rpc.cgi:delByCIDR() so that the caller must explicitly request removal of paired A records when deleting A+PTR or other paired types
• Fix dns-rpc.cgi:zoneStatus() which somehow lost the forward/reverse flag required by DNSDB::zoneStatus()

File:

• trunk/DNSDB.pm (modified) (1 diff)

trunk/DNSDB.pm

@@ -2425 +2425 @@
   local $dbh->{AutoCommit} = 0;
   local $dbh->{RaiseError} = 1;
+
+  return ('FAIL', 'Need a zone identifier to look up') if !$zoneid;
 
   my $msg = '';