Changeset 761 for trunk/dns.cgi

Timestamp:

06/13/17 17:18:56 (7 years ago)

Author:

Kris Deugau

Message:

/trunk

Fix a taint issue using Net::DNS for AXFR with a hostname. Inexplicably,
looking up the IP ourselves and passing that (still tainted!) string in
as the connect host works just fine.

Probably needs further review with newer Net::DNS versions to make sure
this still works, or find a different workaround.

File:

• trunk/dns.cgi (modified) (1 diff)

trunk/dns.cgi

@@ -1734 +1734 @@
     my @results;
     foreach my $domain (@domlist) {
+##fixme: Net::DNS has made changes somewhere between 0.66something (~~ Debian wheezy) and
+# 0.81 (~~ Debian jessie) that cause taint failures when providing a hostname as a nameserver
+# for AXFR.  A proper fix may boil down to "split AXFR into its own script".  Feh.
+# For now, we'll just convert the requested AXFR host to an IP, and pass that down the chain instead.
+      my $nsip = gethostbyname($webvar{ifrom});
+      use Socket;
+      $nsip = inet_ntoa($nsip);
+      # strangely enough we don't seem to need to detaint:
+      #($nsip) = ($nsip =~ /^([a-fA-F0-9:.]+)$/);
       my %row;
-      my ($code,$msg) = $dnsdb->importAXFR($webvar{ifrom}, $domain, $webvar{group},
+      my ($code,$msg) = $dnsdb->importAXFR($nsip, $domain, $webvar{group},
         status => $webvar{domactive}, rwsoa => $webvar{rwsoa}, rwns => $webvar{rwns},
         newttl => ($webvar{forcettl} ? $webvar{newttl} : 0),