Changeset 832 for trunk/dns-rpc.cgi

Timestamp:

03/30/22 14:48:23 (4 years ago)

Author:

Kris Deugau

Message:

/trunk

Replace the hack in r829 with a proper solution:

• Have getRecList() and getRecCount() accept most of the Postgres CIDR operators in the filter argument
• Have dns-rpc.cgi prefix the CIDR to remove with the <<= operator when calling getRecList()

This commit only applies the second part to the "delete everything"
branch of the RPC delByCIDR() sub with known failure cases.

See #77.

File:

• trunk/dns-rpc.cgi (modified) (1 diff)

trunk/dns-rpc.cgi

@@ -1631 +1631 @@
         # Delete ALL EVARYTHING!!one11!! in $args{cidr}
 
-        # Use offset => 'all' to make sure we actually find all the records we need to remove,
-        # otherwise the record(s) that need to be deleted may be more than 75 records down the
-        # list and won't get caught.  We also do a crude filter based on the /24 of $args{cidr}
-        # to reduce the remote's cost for the operation - if the revzone is large, it'll iterate
-        # over a Very Large Number(TM) of records, just to delete a small handful.  Bad juju.
-        my $filt = $args{cidr};
-        $filt =~ s,\.\d+(?:/\d+)?$,,;
+        # Deleting a small $args{cidr} from a large reverse zone will sometimes
+        # silently fail by not finding the appropriate record(s).  Prepend a
+        # Postgres CIDR operator to assist in filtering
+        my $filt = "<<= $args{cidr}";
+
         my $reclist = $dnsdb->getRecList(rpc => 1, defrec => 'n', revrec => 'y', id => $zonelist->[0]->{rdns_id},
             filter => $filt, offset => 'all');