Changeset 93


Ignore:
Timestamp:
04/14/11 16:48:00 (14 years ago)
Author:
Kris Deugau
Message:

/trunk

Remove a couple of ##fixme notes
Log more info on user delete
Extend special-char replacement a little in WHOIS output
Comment a bit on some ##fixme's

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/dns.cgi

    r92 r93  
    664664                $webvar{fname}, $webvar{lname}, $webvar{phone});
    665665        if ($code eq 'OK') {
    666 ##fixme - need to actually get a correct permission set to pass in here,
    667 # also a flag to revert custom permissions to inherited
    668666          $newperms{admin} = 1 if $webvar{accttype} eq 'S';
    669667          ($code,$msg) = changePermissions($dbh, 'user', $webvar{uid}, \%newperms, ($permstring eq 'i'));
     
    817815##fixme: find group id user is in (for logging) *before* we delete the user
    818816##fixme: get other user data too for log
     817    my $userref = getUserData($dbh, $webvar{id});
    819818    my ($code,$msg) = delUser($dbh, $webvar{id});
    820819    if ($code ne 'OK') {
     
    825824    } else {
    826825      # success.  go back to the user list, do not pass "GO"
    827 ##log
    828       logaction(0, $session->param("username"), $curgroup, "Deleted user $webvar{id}");
     826      # actions on users have a domain id of 0, always
     827      logaction(0, $session->param("username"), $curgroup, "Deleted user $webvar{id}/".$userref->{username}.
     828        " (".$userref->{lastname}.", ".$userref->{firstname}.")");
    829829      changepage(page => "useradmin");
    830830    }
     
    961961    $Text::Wrap::columns = 88;
    962962
    963 # &%$@%@# high-bit crap.  We should probably find a way to properly recode these instead of one-by-one.
     963# &%$@%@# high-bit crap.  We should probably find a way to properly recode these
     964# instead of one-by-one.  Note CGI::Simple's escapeHTML() doesn't do more than
     965# the bare minimum.  :/
    964966# Mainly an XHTML validation thing.
     967    $dominfo = $q->escapeHTML($dominfo);
    965968    $dominfo =~ s/\xa9/\©/g;
    966969    $dominfo =~ s/\xae/\®/g;
     
    12691272sub fill_fpnla {
    12701273  my $count = shift;
    1271 ##fixme
    12721274  if ($offset eq 'all') {
    12731275    $page->param(perpage => $perpage);
     
    13311333
    13321334# fill page count and first-previous-next-last-all bits
    1333 ##fixme - hardcoded group bit
    13341335  fill_pgcount($count,"domains",groupName($dbh,$curgroup));
    13351336  fill_fpnla($count);
     
    14871488    $row{groupval} = $groupid;
    14881489##fixme: need magic
     1490## ... WTF?
    14891491#    $row{defgroup} = '';
    14901492    $row{groupactive} = 1 if $groupid == $cur;
     
    16171619  my $entry = shift;
    16181620
    1619 ##fixme: ooohhh, nasty.  what if we get a failure *here*?    PTHBTT!
     1621##fixme: push SQL into DNSDB.pm
    16201622  my $sth = $dbh->prepare("SELECT user_id, firstname || ' ' || lastname FROM users WHERE username=?");
    16211623  $sth->execute($username);
Note: See TracChangeset for help on using the changeset viewer.