Changeset 94

Timestamp:

04/14/11 17:14:23 (14 years ago)

Author:

Kris Deugau

Message:

/trunk

Remove a few stale ##fixme notes
Minor formatting nitpick cleanup
Use "SELECT currval..." when adding a user to get the new user ID
Remove stale stub editRecord() since it's been superceded by updateRec()

File:

• trunk/DNSDB.pm (modified) (6 diffs)

trunk/DNSDB.pm

@@ -240 +240 @@
 # Update an ACL entry
 # Takes a db handle, type, owner-id, and hashref for the changed permissions.
-##fixme: Must handle case of changing object's permissions from custom to inherited
 sub changePermissions {
   my $dbh = shift;
@@ -735 +734 @@
   local $dbh->{RaiseError} = 1;
 
-my $failmsg;
+  my $failmsg = '';
+
   # Wrap all the SQL in a transaction
   eval {
@@ -746 +746 @@
 
     # get the ID...
-    $sth = $dbh->prepare("select user_id from users where username=?");
-    $sth->execute($username);
-    ($user_id) = $sth->fetchrow_array();
+    ($user_id) = $dbh->selectrow_array("SELECT currval('users_user_id_seq')");
 
 # Permissions!  Gotta set'em all!
@@ -788 +786 @@
 
 ##fixme: add another table to hold name/email for log table?
-#die "dying horribly ($permstring, $user_id)";
 
     # once we get here, we should have suceeded.
@@ -969 +966 @@
 
 
-## DNSDB::editRecord()
-# Change an existing record
-# Takes a database handle, default/live flag, record ID, and new data and updates the data fields for it
-sub editRecord {
-  $errstr = '';
-  my $dbh = shift;
-  my $defflag = shift;
-  my $recid = shift;
-  my $host = shift;
-  my $address = shift;
-  my $distance = shift;
-  my $weight = shift;
-  my $port = shift;
-  my $ttl = shift;
-}
-
-
 ## DNSDB::getSOA()
 # Return all suitable fields from an SOA record in separate elements of a hash
@@ -1080 +1060 @@
   }
   $sql .= " AND NOT r.type=$reverse_typemap{SOA} ORDER BY r.$order $direction";
-##fixme:  need to set nstart properly (offset is not internally multiplied with limit)
   $sql .= " LIMIT $nrecs OFFSET ".($nstart*$nrecs) if $nstart ne 'all';