Changeset 189 for trunk/cgi-bin/IPDB.pm

Timestamp:

03/08/05 17:37:46 (19 years ago)

Author:

Kris Deugau

Message:

/trunk

Caught some buglets in the HairyPerl(TM) ('$1' vs "$1")
Corrected a potentially annoying SQL buglet relating to the

selection of which netblock an allocation is to be taken from;
under certain conditions it would pick a larger block to slice
up while there was still a perfectly usable block just the
right size waiting to be allocated.

Removed display of back-end alloctypes from success/failure notes
Corrected comments referring to alloctypes that have been altered
Updated IPDB "default" schema and alloctypes list with current

base information

File:

• trunk/cgi-bin/IPDB.pm (modified) (4 diffs)

trunk/cgi-bin/IPDB.pm

@@ -332 +332 @@
           $sth->execute;
 
-        } else { # done with alloctype == rr
+        } else { # done with alloctype == rm
 
           # Insert the new freeblocks entries
@@ -339 +339 @@
           $sth = $dbh->prepare("insert into freeblocks (cidr,maskbits,city,routed)".
                 " values (?, ?, (select city from routed where cidr >>= '$cidr'),'".
-                (($type =~ /^(.)r$/) ? '$1' : 'y')."')");
+                (($type =~ /^(.)r$/) ? "$1" : 'y')."')");
           foreach my $block (@newfreeblocks) {
             $sth->execute("$block", $block->masklen);
@@ -370 +370 @@
           }
 
-        } # done with netblock alloctype != rr
+        } # done with netblock alloctype != rm
 
         $dbh->commit;
@@ -577 +577 @@
                 " values ('$cidr',".$cidr->masklen.
                 ",(select city from routed where cidr >>= '$cidr'),'".
-                (($type =~ /^(.)r$/) ? '$1' : 'y')."')");
+                (($type =~ /^(.)r$/) ? "$1" : 'y')."')");
       }
       $sth->execute;