Opened 9 years ago

Closed 5 years ago

#15 closed enhancement (fixed)

Switch CGI handling to (semi-)standard third-party modules

Reported by: kdeugau Owned by:
Priority: major Milestone: 2.8
Version: Keywords:
Cc:

Description

Specifically, CGI::Simple. This will allow removal of dangling semi-legacy module CommonWeb?.pm (which has been hacked up a fair bit to paper over problems, but whose subs are increasingly irrelevant).

Change History (20)

comment:1 Changed 9 years ago by kdeugau

(In [415]) /trunk

Genericize and comment a lurking mailNotify() call. See #2.
Remove a couple of stale, legacy, irrelvant comments.
Genericize another email address reference. See #2 (sort of).
Remove a legacy sub that's never been used, from a module due
to be removed itself. See #15.

comment:2 Changed 8 years ago by kdeugau

  • Milestone set to 3.0

comment:3 Changed 8 years ago by kdeugau

(In [446]) Create branch for HTML cleanup (see #3) and CGI normalization/cleanup
(see #15). Changes for one will affect the other; better to handle
them in the same workflow.

comment:4 Changed 8 years ago by kdeugau

(In [447]) /branches/htmlform

Switch all scripts to use CGI::Simple for HTML form data munging
instead of legacy CommonWeb?.pm sub. Remove parse_post() sub from
CommonWeb?.pm. See #15.

comment:5 Changed 8 years ago by kdeugau

(In [448]) /branches/htmlform

Escape forwarded form data with $q->escapeHTML on most forms in
main.cgi (see #15)
Fix up most subs in IPDB.pm that deal with form data that needs
escaping (see #34)

comment:6 Changed 8 years ago by kdeugau

(In [479]) /branches/htmlform

Convert initial DB connection error output to a sane page. Could arguably provide
space for this (and other) errors on all normal pages. (See #3).
This allows us to:

  • Remove editError sub in main.cgi
  • Remove printHeader sub in CommonWeb?.pm (see #15, #26)

Removed duplicate "exit if we get this far"
Tweak IPDB::finish so it doesn't spit a fatal error when called with a null database handle

comment:7 Changed 8 years ago by kdeugau

(In [480]) /branches/htmlform

Forgot to remove some refs to printHeader in CommonWeb?.pm in r479 (see #15, #26)
Add the Invitable Forgotten New File (DB error template)

comment:8 Changed 8 years ago by kdeugau

(In [481]) /branches/htmlform

Update search.cgi to use a few templates (see #3 - note search.cgi NOT completely
updated for HTML only in templates), remove search.cgi references to printError
from CommonWeb?.pm (see #15, #26).

comment:9 Changed 8 years ago by kdeugau

(In [483]) /branches/htmlform

Start converting admin.cgi to templates (to make removal of references to CommonWeb?.pm
subs simpler; see #3, #15, #26)
Completed:

  • Main page
  • ACL error page
  • rWHOIS customer data editing - list, edit new/update, confirm update

comment:10 Changed 8 years ago by kdeugau

(In [487]) /branches/htmlform

Finish IP pool tweaking
Complete email notice configuration
Finish most of block allocation
Add generic error page
Fix admin header with reference to Javascript bits
See #3, #15, #26

comment:11 Changed 8 years ago by kdeugau

(In [489]) /branches/htmlform

Remove use of printError() in admin.cgi. See #15, #26

comment:12 Changed 8 years ago by kdeugau

(In [490]) /branches/htmlform

Remove ref to printAndExit from allocate.pl (irrelevant anyway since it's not a web
tool). See #3, #15, #26.

comment:13 Changed 8 years ago by kdeugau

(In [491]) /branches/htmlform

Convert dangling DB error to template in admin.cgi; remove all refs to printAndExit().
See #3, #15, #26.

comment:14 Changed 8 years ago by kdeugau

(In [495]) /branches/htmlform

Converted main.cgi "invalid action" into template. See #3.
"Cleaned up" error messages for an invalid action, removed call to printAndExit(). See #15, #26.

comment:15 Changed 7 years ago by kdeugau

(In [502]) /branches/htmlform

Remove stale, unused cleanInput(), desanitize() subs in CommonWeb?.pm
Quickly hack up search.cgi to remove printAndExit() from CommonWeb?.pm
See #15, #26

comment:16 Changed 7 years ago by kdeugau

(In [503]) /branches/htmlform

Checkpoint, clearing out references to printError()
All ACL checks that generate error pages should now be converted
to use the new aclerror template. See #15.
Fix a minor bug in CustIDCK.pm - calls to custid_check are being
treated as an object call for some reason.

comment:17 Changed 7 years ago by kdeugau

(In [504]) /branches/htmlform

Convert all but one remaining call to printError to use the
designated error space in the relevant templates
Also make sure to actually generate an error on a missing POP
for new allocations
See #15.

comment:18 Changed 7 years ago by kdeugau

(In [505]) /branches/htmlform

Clean up final reference to printError(), and remove all references
(commented or otherwise) to CommonWeb?.pm. Remove the file itself. See #15.
Tweak block-update template for error handling. See #3.

comment:19 Changed 6 years ago by kdeugau

  • Milestone changed from 3.0 to 2.8

comment:20 Changed 5 years ago by kdeugau

  • Resolution set to fixed
  • Status changed from new to closed

Resolving since the legacy module has been removed, the changes merged from the working branch /branches/htmlform to /trunk (r517), and as of r593 into the stable branch.

Note: See TracTickets for help on using tickets.