#3 closed enhancement (fixed)
HTML output cleanup
Reported by: | Kris Deugau | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | 3.0 |
Version: | Keywords: | ||
Cc: |
Description (last modified by )
Convert all HTML output to HTML 4.01 strict (or closest relative) and HTML::Template
Change History (58)
comment:1 Changed 14 years ago by
Priority: | major → critical |
---|
comment:2 Changed 14 years ago by
comment:3 Changed 13 years ago by
Milestone: | → 3.0 |
---|
comment:4 Changed 13 years ago by
comment:5 Changed 13 years ago by
(In [449]) /branches/htmlform
Remove printFooter from CommonWeb?.pm
Add HTML::Template to main.cgi, admin.cgi, and search.cgi
Convert footer.inc to templates/footer.tmpl, and normalize
output for three scripts above
See #3.
comment:6 Changed 13 years ago by
comment:7 Changed 13 years ago by
Description: | modified (diff) |
---|
As per notes and thoughts at:
http://www.hixie.ch/advocacy/xhtml
http://hsivonen.iki.fi/doctype/
don't bother with XHTML (since it's guaranteed to be mishandled somewhere), just go with HTML 4.01 strict.
comment:8 Changed 13 years ago by
(In [451]) /branches/htmlform
Move Javascript from the header into its own file
Convert index page (master block summary) to template
Convert header to template, use template header in main.cgi
and search.cgi - going to leave admin.cgi out for now
Update HTML in header, index, footer to HTML 4.01 strict
See #3.
comment:9 Changed 13 years ago by
comment:10 Changed 13 years ago by
comment:11 Changed 13 years ago by
comment:12 Changed 13 years ago by
(In [459]) /branches/htmlform
Convert "new city" miniscript and page to template, move the "reload
parent" JavaScript? fragment into widgets.js. See #3.
Update calls from assign.tmpl and admin.cgi to point to newcity.cgi.
comment:13 Changed 13 years ago by
comment:14 Changed 13 years ago by
comment:15 Changed 13 years ago by
(In [463]) /branches/htmlform
Validation nitpick fix in assign.tmpl - also fixes missing field
name on alloctype list. <headdesk>
Convert new assignment result page to template.
Add missing error handling, missing IP pool selection on confirm.tmpl
Create footer template object earlier to allow pushing bits into
it during processing
Prepare to move initial output further down execution to prepare for
proper error handling in subs
Fix probable bug introduced with r456 where the "Routing" type isn't
available when it should be. Maybe. Probably.
Error messages for sub insertAssign() and confirmAssign could arguably
be further moved into the templates, but the complexity of the template
would go *way* up with little or no benefit.
See #3.
comment:16 Changed 13 years ago by
comment:17 Changed 13 years ago by
comment:18 Changed 13 years ago by
(In [466]) /branches/htmlform
Give up on proper spelling of "centre" in CSS class names and
defs - browsers only understand an alignment of "center".
Adjust width of some <hr>'s
Visual row0/row1 classes got switched somehow, somewhere
Remove legacy "color0/color1/color2" row class defs
Convert showrouted to template
See #3.
comment:19 Changed 13 years ago by
comment:20 Changed 13 years ago by
comment:21 Changed 13 years ago by
(In [470]) /branches/htmlfrom
Block edit page should be complete and even valid.
Still has some slight fishyness with column edges not aligned due
to stupid "can't start a form in between table rows" validation spec
idiocy. (<table><form><tr>...</tr></form><form><tr>...</tr></form></table>
is not valid for strict HTML 4.01.)
See #3.
comment:22 Changed 13 years ago by
comment:23 Changed 13 years ago by
comment:24 Changed 13 years ago by
comment:25 Changed 13 years ago by
comment:26 Changed 13 years ago by
comment:27 Changed 13 years ago by
comment:28 Changed 13 years ago by
comment:29 Changed 13 years ago by
(In [478]) /branches/htmlfrom
Set a global variable so we can move the site to any level of
web directory. See #17 - note this is an internal autoconfiguration
that shouldn't need to be exposed.
Make code/template structure for setting row colours in tables more
consistent - also tweak search.cgi so it spits out live colour
classes. See #3.
comment:30 Changed 13 years ago by
(In [479]) /branches/htmlform
Convert initial DB connection error output to a sane page. Could arguably provide
space for this (and other) errors on all normal pages. (See #3).
This allows us to:
- Remove editError sub in main.cgi
- Remove printHeader sub in CommonWeb?.pm (see #15, #26)
Removed duplicate "exit if we get this far"
Tweak IPDB::finish so it doesn't spit a fatal error when called with a null database handle
comment:31 Changed 13 years ago by
(In [481]) /branches/htmlform
Update search.cgi to use a few templates (see #3 - note search.cgi NOT completely
updated for HTML only in templates), remove search.cgi references to printError
from CommonWeb?.pm (see #15, #26).
comment:32 Changed 13 years ago by
comment:33 Changed 13 years ago by
(In [483]) /branches/htmlform
Start converting admin.cgi to templates (to make removal of references to CommonWeb?.pm
subs simpler; see #3, #15, #26)
Completed:
- Main page
- ACL error page
- rWHOIS customer data editing - list, edit new/update, confirm update
comment:34 Changed 13 years ago by
comment:35 Changed 13 years ago by
comment:36 Changed 13 years ago by
comment:37 Changed 13 years ago by
comment:38 Changed 13 years ago by
comment:39 Changed 13 years ago by
comment:40 Changed 13 years ago by
comment:41 Changed 13 years ago by
comment:42 Changed 13 years ago by
comment:43 Changed 12 years ago by
comment:44 Changed 12 years ago by
comment:45 Changed 12 years ago by
comment:46 Changed 12 years ago by
comment:47 Changed 12 years ago by
comment:48 Changed 12 years ago by
(In [505]) /branches/htmlform
Clean up final reference to printError(), and remove all references
(commented or otherwise) to CommonWeb?.pm. Remove the file itself. See #15.
Tweak block-update template for error handling. See #3.
comment:49 Changed 11 years ago by
comment:50 Changed 11 years ago by
comment:51 Changed 11 years ago by
comment:52 Changed 11 years ago by
comment:53 Changed 11 years ago by
comment:54 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:55 Changed 11 years ago by
comment:56 Changed 11 years ago by
(In [536]) /trunk
Clean up and move SQL for post-update backlink to IPDB.pm. See #34.
Also rename getParent() to subParent() to fit in with ipParent() and
blockParent().
Fix a couple "Use of uninitialized..." log-noise bugs. See #31.
Move some HTML-entity-escaping into the template, and shuffle lines
munging the notes and restricted data on post-update value display
so we can properly munge in <br> for \n. Doesn't seem to be a way
to plug that into HTML::Template. :( See #3.
(In [413]) /trunk